Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec: Don't convert set or enum datum to float64 #32372

Merged
merged 11 commits into from
Feb 23, 2022
Merged

codec: Don't convert set or enum datum to float64 #32372

merged 11 commits into from
Feb 23, 2022

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Feb 15, 2022

What problem does this PR solve?

Issue Number: close #32302

Problem Summary:

Missing part of #32308

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2022
@ekexium
Copy link
Contributor Author

ekexium commented Feb 16, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Feb 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/df092621ace655ef05f1e5c9e76cc54a702239fd

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2022
@ekexium
Copy link
Contributor Author

ekexium commented Feb 17, 2022

/assign @cfzjywxk

@MyonKeminta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 40b385b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@MyonKeminta
Copy link
Contributor

/run-unit-test

cfzjywxk
cfzjywxk approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit cc789d0 into pingcap:master Feb 23, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ekexium @ti-srebot
cherry pick pingcap#32372 to release-4.0
8a2fc67 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32561

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ekexium @ti-srebot
cherry pick pingcap#32372 to release-5.0
7c1670f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32562

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ekexium @ti-srebot
cherry pick pingcap#32372 to release-5.1
61ae903 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32563

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ekexium @ti-srebot
cherry pick pingcap#32372 to release-5.2
1efcd51 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32564

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ekexium @ti-srebot
cherry pick pingcap#32372 to release-5.3
1325e54 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32565

@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ekexium @ti-srebot
cherry pick pingcap#32372 to release-5.4
e76af46 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32566

ekexium added a commit to ti-srebot/tidb that referenced this pull request Feb 24, 2022
@ekexium
cherry pick: codec: Don't convert set or enum datum to float64 (pingc…
6e76de0 
…ap#32372)

close pingcap#32302

Signed-off-by: ekexium <[email protected]>
ekexium added a commit to ti-srebot/tidb that referenced this pull request Feb 24, 2022
@ekexium
cherry pick: codec: Don't convert set or enum datum to float64 (pingc…
da6a3fc 
…ap#32372)

close pingcap#32302

Signed-off-by: ekexium <[email protected]>
ekexium added a commit to ti-srebot/tidb that referenced this pull request Feb 24, 2022
@ekexium
codec: Don't convert set or enum datum to float64 (pingcap#32372)
f6cc6f5 
close pingcap#32302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@cfzjywxk cfzjywxk

Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using set as primary key results in inconsistent index
8 participants
@ekexium @ti-chi-bot @sre-bot @MyonKeminta @hawkingrei @ti-srebot @cfzjywxk @wjhuang2016