ddl: rename a non exist table report right error message(issue:#29893)

[fanrenhoo]

Signed-off-by: fanrenhoo [email protected]

What problem does this PR solve?

Issue Number: close #29893

Problem Summary:

What is changed and how it works?

in executor/ddl.go, in "func (e *DDLExec) executeRenameTable"
add new line:243 "isAlterTable := true"
in this "if branch" should be a altertable case, so set this value to "true"

I tested in my local branch, it worked, like:

use dbtest;
Database changed
rename table db1 to db2;
ERROR 1146 (42S02): Table 'dbtest.db1' doesn't exist

Check List

executor/ddl.go

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
  I tested in my local branch, before fix its like what the issue described, now it worked:
  the steps is as:

create database dbtest;
use dbtest;
Database changed
rename table db1 to db2;
ERROR 1146 (42S02): Table 'dbtest.db1' doesn't exist

• No code

Side effects

should no side effect

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

nothing change to Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release-note

fix the issue "Rename a non exist table report wrong error message"(issue:#29893) 
while rename noexist table, before fix the error message like: "ERROR 1017 (HY000): Can't find file: 'db_optimistic' (errno: {%!d(string=tb1) %!d(string=tb1)} - %!s(MISSING))"
after fix give the correct message "ERROR 1146 (42S02): Table 'dbtest.db1' doesn't exist"

/cc @xiongjiwei

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Please follow PR Title Format:

• pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

• *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

[fanrenhoo]

/cc @xiongjiwei

[sre-bot]

Please follow PR Title Format:

• pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

• *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

[sre-bot]

Please follow PR Title Format:

• pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

• *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

[xiongjiwei]

Please follow PR Title Format:

• pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

• *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

please follow the comment, the PR title should be like ddl: xxx in this case.

[xiongjiwei]

the point is the error message is not the same with MySQL. We'd better change the error message.

BTW, in the previous code, isAlterTable is always false. I think it can be removed. you can see the commit which introduced this variable.

[xiongjiwei]

please also add a test for this case