Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix weak consistency not work (#31935) #31949

Merged
merged 1 commit into from
Jan 25, 2022
Merged

*: fix weak consistency not work (#31935) #31949

merged 1 commit into from
Jan 25, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 25, 2022 •
edited
Loading

cherry-pick #31935 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/31949

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/31949:release-5.4-9e928b2321e9

Signed-off-by: you06 [email protected]

What problem does this PR solve?

Issue Number: close #31933

Problem Summary:

What is changed and how it works?

#30943 allows TiDB read by TiKV's RC but with a wrong implementation. This PR merges the RC usage into SetFromSessionVars and fix the issue that the weak-consistency read does not work.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that the weak-consistency read does not work.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 25, 2022
@ti-srebot ti-srebot mentioned this pull request Jan 25, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.4-cherry-pick labels Jan 25, 2022
@ti-srebot
Copy link
Contributor Author

@you06 you're already a collaborator in bot's repo.

@cfzjywxk cfzjywxk added the sig/transaction SIG:Transaction label Jan 25, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022
@cfzjywxk
Copy link
Contributor

@youjiali1995 @zyguan PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2022
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a12ad22

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022
@cfzjywxk
Copy link
Contributor

@zhouqiang-cl
PTAL a blocking merge.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2022
@zhouqiang-cl zhouqiang-cl removed the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2022
@zhouqiang-cl zhouqiang-cl added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 25, 2022
@zhouqiang-cl
Copy link
Contributor

@ti-chi-bot

@ti-chi-bot ti-chi-bot merged commit 55f3b24 into pingcap:release-5.4 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@TonsnakeLin TonsnakeLin Awaiting requested review from TonsnakeLin

@zyguan zyguan Awaiting requested review from zyguan

Assignees

@you06 you06

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @cfzjywxk @zhouqiang-cl @youjiali1995 @you06