Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* : replace fmt.Sprint with strconv #31718

Merged
merged 5 commits into from
Jan 17, 2022
Merged

* : replace fmt.Sprint with strconv #31718

merged 5 commits into from
Jan 17, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 15, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #31716

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/16a7c0e9c6bc6ed65b48c703b35e1cb1511a714f

@hawkingrei hawkingrei requested a review from a team as a code owner January 15, 2022 17:08
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Jan 15, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@siddontang
Copy link
Member

the reference issue doesn't show anything, so why do we do this?

@hawkingrei
Copy link
Member Author

hawkingrei commented Jan 17, 2022 •
edited
Loading

the reference issue doesn't show anything, so why do we do this?

When converting primitives to/from strings, strconv is faster than fmt.

@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei hawkingrei requested a review from kennytm January 17, 2022 05:45
kennytm
kennytm approved these changes Jan 17, 2022
View reviewed changes
expression/generator/other_vec.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1d4bd84

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 465f655 into pingcap:master Jan 17, 2022
@hawkingrei hawkingrei deleted the improve_code_sty branch January 17, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hawkingrei @ti-chi-bot @sre-bot @siddontang @tangenta @kennytm @qw4990