-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add tidb_enable_direct_placement
to default forbid direct placement
#31623
*: Add tidb_enable_direct_placement
to default forbid direct placement
#31623
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
… into disable_direct_placement
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9d559d0f237cf628ca5348b46c76fed04d97cdf8 |
/run-mysql-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ea18796
|
@lcwangchao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #31622
Problem Summary:
In #31423 we removed direct placement options from the design of placement rules in SQL. We plan to remove these from code (time permitting), but it is difficult to remove them all at once because they are all thoroughly integrated into tests.
This introduces a new temporary variable to we can prohibit the syntax from users, but allow the current tests to run without breaking. Eventually once all the code is cleaned up and tests are fixed we can remove this variable.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note