Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: make queries with the extra column _tidb_rowid can use PointGet #31562

Closed
wants to merge 2 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 11, 2022

What problem does this PR solve?

Issue Number: close #31543

Problem Summary: planner: make queries with the extra column _tidb_rowid can use PointGet

What is changed and how it works?

planner: make queries with the extra column _tidb_rowid can use PointGet

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

planner: make queries with the extra column `_tidb_rowid` can use PointGet

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 11, 2022
@qw4990 qw4990 requested a review from tiancaiamao January 11, 2022 08:56
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2022
@qw4990 qw4990 requested a review from XuHuaiyu January 11, 2022 08:56
@qw4990 qw4990 closed this Jan 20, 2022
@qw4990 qw4990 reopened this Mar 1, 2022
@qw4990 qw4990 closed this Mar 1, 2022
@ti-chi-bot
Copy link
Member

@qw4990: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

point_get is not chosen as expected
2 participants