Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: make queries with the extra column _tidb_rowid can use PointGet #31552

Merged
merged 4 commits into from
Jan 11, 2022
Merged

planner: make queries with the extra column _tidb_rowid can use PointGet #31552

merged 4 commits into from
Jan 11, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 11, 2022

What problem does this PR solve?

Issue Number: close #31543

Problem Summary: planner: make queries with the extra column _tidb_rowid can use PointGet

What is changed and how it works?

planner: make queries with the extra column _tidb_rowid can use PointGet

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

planner: make queries with the extra column `_tidb_rowid` can use PointGet

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Jan 11, 2022
@ti-chi-bot
Copy link
Member

@qw4990: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2022
XuHuaiyu
XuHuaiyu previously approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1028cbe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2022
@zhouqiang-cl zhouqiang-cl merged commit e63ee3f into pingcap:release-5.3-20211223 Jan 11, 2022
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
qw4990 added a commit to qw4990/tidb that referenced this pull request Mar 1, 2022
@qw4990
planner: make queries with the extra column _tidb_rowid can use Poi…
71725ca 
…ntGet (pingcap#31552)

* fixup
@qw4990 qw4990 mentioned this pull request Mar 1, 2022
Merged
12 tasks
qw4990 added a commit to qw4990/tidb that referenced this pull request Mar 1, 2022
@qw4990
planner: make queries with the extra column _tidb_rowid can use Poi…
2118696 
…ntGet (pingcap#31552)

* fixup
zhouqiang-cl pushed a commit that referenced this pull request Mar 2, 2022
@qw4990
planner: make queries with the extra column _tidb_rowid can use Poi…
3d6475d 
…ntGet (#31552) (#32704)

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@qw4990 @ti-chi-bot @tiancaiamao @XuHuaiyu @purelind @zhouqiang-cl