Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: make explain_test can test collation-related tests with new-collation disabled #31385

Merged
merged 11 commits into from
Jan 10, 2022
Merged

cmd: make explain_test can test collation-related tests with new-collation disabled #31385

merged 11 commits into from
Jan 10, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jan 6, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Issue Number: close #31384

Problem Summary:

What is changed and how it works?

  1. The test involves collation, and the test files are prefixed with collation.
  2. The default configuration is new collation, and another configuration turns off the new collation.
  3. After the default test runs all tests, use the configuration of disabling new collation to run collation-related tests.
  4. The results of tests with new collation open have the suffix enabled and closed have the suffix disabled.
    For example collation_test1, the result file is collation_test1_enabled, collation_test1_disabled
  5. In the explaintest main.go. Modify resultFileName() to control the collation result file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
try
2a2e19d 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2022
@wjhuang2016
remove
4e57f32 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
merge
6fa14d0 
Signed-off-by: wjhuang2016 <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/88f630b9e5774997b81b18da24c10f77bf5d6393

@wjhuang2016
address comment
ac55747 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ac55747

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2022
@wjhuang2016
Copy link
Member Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@wjhuang2016: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016
Copy link
Member Author

/run-unit-test

@wjhuang2016
Copy link
Member Author

/run-check_dev_2

@wjhuang2016
Copy link
Member Author

@ti-chi-bot

1 similar comment
@wjhuang2016
Copy link
Member Author

@ti-chi-bot

@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot merged commit 28c5074 into pingcap:master Jan 10, 2022
@wjhuang2016 wjhuang2016 deleted the explain_coll branch November 17, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance explain_test to make it test collation-related tests with new-collation disabled.
5 participants
@wjhuang2016 @ti-chi-bot @sre-bot @xiongjiwei @tangenta