Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: refactor sendBackup #31264

Merged
merged 6 commits into from
Jan 25, 2022
Merged

br: refactor sendBackup #31264

merged 6 commits into from
Jan 25, 2022

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jan 4, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #31374
Problem Summary:
refactor SendBackup to reduce cyclomatic complexities from 18 to 7.

What is changed and how it works?

refactor SendBackup

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

run gocyclo br/pkg/backup/client.go

before this PR.

18 backup SendBackup br/pkg/backup/client.go:892:1

after this PR.

7 backup SendBackup br/pkg/backup/client.go:954:1

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2022
@3pointer
Copy link
Contributor Author

3pointer commented Jan 4, 2022

/run-integration-br-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e765c4ff68aaecffd6ffd1257f3e460b283757d5

@3pointer 3pointer mentioned this pull request Jan 5, 2022
Merged
2 tasks
@3pointer 3pointer force-pushed the refactor_send_backup branch from 051dad2 to 1747c8f Compare January 6, 2022 06:40
@3pointer
Copy link
Contributor Author

3pointer commented Jan 6, 2022

/run-integration-br-tests

@3pointer 3pointer marked this pull request as ready for review January 8, 2022 07:34
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2022
@3pointer 3pointer requested review from kennytm and YuJuncen January 10, 2022 08:30
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2022
@kennytm
Copy link
Contributor

kennytm commented Jan 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8e37fcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022
@ti-chi-bot ti-chi-bot merged commit bb42313 into pingcap:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3pointer @ti-chi-bot @sre-bot @kennytm @YuJuncen