-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: support batch create table (#28763) #31234
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@xhebox you're already a collaborator in bot's repo. |
closed, since nobody needs it. |
cherry-pick #28763 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/31234
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: refer #30272
Problem Summary: add an internal batch create table api for br, all happens in one schema version.
Some notes on the behavior:
query
since it is not from parser. One must setctx.Value(sessionctx.QueryString)
manually for displayingadmin show ddl queries
.admin show ddl jobs
can not show multiple ids intableID
column, but will show comma separated list of table names intableName
column.What is changed and how it works?
What's Changed:
CreateTablesWithInfo
, the new batch api.CreateTableWithInfo
andCreateTablesWithInfo
are extracted.onCreateTable
andonCreateTables
are extracted.db_test.go
andtable_test.go
.Affected []HistoryInfoAffected
inbinlog.HistoryInfo
for display multiple table names.Check List
Tests
Side effects
Documentation
Release note