Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support batch create table (#28763) #31234

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 31, 2021

cherry-pick #28763 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/31234

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/31234:release-5.4-4f30a14256c1

What problem does this PR solve?

Issue Number: refer #30272

Problem Summary: add an internal batch create table api for br, all happens in one schema version.

Some notes on the behavior:

  1. This API does not set query since it is not from parser. One must set ctx.Value(sessionctx.QueryString) manually for displaying admin show ddl queries.
  2. admin show ddl jobs can not show multiple ids in tableID column, but will show comma separated list of table names in tableName column.

What is changed and how it works?

What's Changed:

  1. add CreateTablesWithInfo, the new batch api.
  2. Common part in CreateTableWithInfo and CreateTablesWithInfo are extracted.
  3. Common part in onCreateTable and onCreateTables are extracted.
  4. add simple unit tests in db_test.go and table_test.go.
  5. add Affected []HistoryInfoAffected in binlog.HistoryInfo for display multiple table names.
  6. When the job is cancelled, its arguments will be deleted. Since someone may issued a super large job that does not fit into the history queue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 31, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 31, 2021
12 tasks
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 31, 2021
@ti-srebot ti-srebot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.4-cherry-pick labels Dec 31, 2021
@ti-srebot
Copy link
Contributor Author

@xhebox you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021
@xhebox
Copy link
Contributor

xhebox commented Mar 10, 2022

closed, since nobody needs it.

@xhebox xhebox closed this Mar 10, 2022
@JaySon-Huang JaySon-Huang deleted the release-5.4-4f30a14256c1 branch March 10, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants