plan: new plan support hash aggregation. #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Apr 24, 2017
| if task != nil { | ||
| return task, nil | ||
| } | ||
| task, err = p.convert2HashAggregation(prop) |
There was a problem hiding this comment.
We will support streaming aggregation latter?
| } | ||
| partialAgg = p.Copy().(*PhysicalAggregation) | ||
| // TODO: It's toooooo ugly here. Refactor in the future !! | ||
| gkType := types.NewFieldType(mysql.TypeBlob) |
coocood
reviewed
Apr 25, 2017
plan/task_profile.go
Outdated
| gkType.Collate = charset.CollationBin | ||
| partialSchema := expression.NewSchema(&expression.Column{RetType: gkType, FromID: p.id, Index: 0}) | ||
| cursor := 0 | ||
| newAggFuncs := make([]expression.AggregationFunction, len(finalAgg.AggFuncs)) |
There was a problem hiding this comment.
finalAggFunc is a more consistent name.
|
rest LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we only support hash aggregation.
@shenli @coocood @zimulala @tiancaiamao PTAL