Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: buildWindow cannot call typeInfer twice (#30773) #30865

Merged
merged 44 commits into from
Jun 22, 2022
Merged

executor: buildWindow cannot call typeInfer twice (#30773) #30865

merged 44 commits into from
Jun 22, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 20, 2021 •
edited
Loading

cherry-pick #30773 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30865

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/30865:release-5.3-e3c56b75eaeb

What problem does this PR solve?

Issue Number: close #30402

Problem Summary: build window desc call TypeInfer twice, which change the return type incorrectly. For example, avg() in window func, a int type is first inferred to decimal(15,4), then inferred to decimal(19,8), which breaks compatibility with mysql.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 20, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 20, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 20, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick type/bugfix This PR fixes a bug. labels Dec 20, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2021
@ti-srebot
Copy link
Contributor Author

@fzhedu you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

@fzhedu merge remainder

@guo-shaoge
Copy link
Collaborator

/run-check_dev
/run-mysql-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 23, 2022
@guo-shaoge
Copy link
Collaborator

/run-mysql-test

windtalker
windtalker approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2022
XuHuaiyu
XuHuaiyu approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu
Copy link
Contributor

/merge

@XuHuaiyu
Copy link
Contributor

/run-unit-test

@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 20, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/run-unit-test

@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/merge

1 similar comment
@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/merge

@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/61096bbd8cc3cd05e75384bb33040e7fa6416366

@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/merge

@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/61096bbd8cc3cd05e75384bb33040e7fa6416366

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 22, 2022
@ti-chi-bot ti-chi-bot merged commit d2a264a into pingcap:release-5.3 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@windtalker windtalker windtalker approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees

@fzhedu fzhedu

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.3-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ti-srebot @ti-chi-bot @guo-shaoge @hawkingrei @XuHuaiyu @fzhedu @sre-bot @windtalker @VelocityLight