-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: track the memory usage of IndexJoin more accurate (#29068) #30093
*: track the memory usage of IndexJoin more accurate (#29068) #30093
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@XuHuaiyu you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 86db918
|
/merge |
cherry-pick #29068 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30093
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #28650
Problem Summary:
The memory usage of
indexJoinBuilderHelper.buildTemplateRange
andindexRangesToKVWithoutSplit
is not tracked. Thus we can not cancel the SQL which uses IndexJoin with hugenextColRanges
even if it costs a lot of memory.What is changed and how it works?
After this commit, the SQL can be cancelled when reaching the memory quota.
Check List
Tests
test.txt
Side effects
But this regression can be ignored since the newly added memory tracking is a low-frequency action.
Documentation
N/A
Release note