*: support Super_priv #2990
Merged
*: support Super_priv #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
zimulala
reviewed
Apr 5, 2017
| @@ -47,6 +47,7 @@ const ( | |||
| Grant_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
| Alter_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
| Show_db_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
| Super_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
| Execute_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
| Index_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
| Create_user_priv ENUM('N','Y') NOT NULL DEFAULT 'N', | |||
There was a problem hiding this comment.
Seems it github's bug, it's actually formated.
| mustExec(c, se, `INSERT INTO mysql.user VALUES ("%", "root1", "admin", "N", "Y", "N", "N", "N", "N", "N", "N", "N", "N", "N", "N")`) | ||
| mustExec(c, se, `INSERT INTO mysql.user VALUES ("%", "root11", "", "N", "N", "Y", "N", "N", "N", "N", "N", "Y", "N", "N", "N")`) | ||
| mustExec(c, se, `INSERT INTO mysql.user VALUES ("%", "root111", "", "N", "N", "N", "N", "N", "N", "N", "N", "Y", "Y", "Y", "Y")`) | ||
| // Host | User | Password | Select_priv | Insert_priv | Update_priv | Delete_priv | Create_priv | Drop_priv | Grant_priv | Alter_priv | Show_db_priv | Super_priv | Execute_priv | Index_priv | Create_user_priv |
There was a problem hiding this comment.
Your operation of add column doesn't use after, so this schema will be Host | User | Password | Select_priv | Insert_priv | Update_priv | Delete_priv | Create_priv | Drop_priv | Grant_priv | Alter_priv | Show_db_priv | Execute_priv | Index_priv | Create_user_priv | Super_priv
|
LGTM |
zimulala
approved these changes
Apr 5, 2017
zimulala
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Super_privtomysql.usertable and use it.