Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: generate PointGet plans for PlanCache when all conditions are EQ #29859

Merged
merged 5 commits into from
Nov 17, 2021
Merged

planner: generate PointGet plans for PlanCache when all conditions are EQ #29859

merged 5 commits into from
Nov 17, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 17, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #29850

Problem Summary: planner: generate PointGet plans for PlanCache when all conditions are EQ

What is changed and how it works?

planner: generate PointGet plans for PlanCache when all conditions are EQ

Check List

Tests

  • Unit test

Release note

None

@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. type/bugfix This PR fixes a bug. sig/planner SIG: Planner epic/plan-cache affects-5.3 This bug affects 5.3.x versions. labels Nov 17, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2021
@qw4990 qw4990 changed the title [WIP] planner: generate PointGet plans for PlanCache when all conditions are EQ planner: generate PointGet plans for PlanCache when all conditions are EQ Nov 17, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2021
@qw4990 qw4990 requested a review from winoros November 17, 2021 06:54
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d77f742

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 17, 2021
@ti-chi-bot ti-chi-bot merged commit 2767218 into pingcap:master Nov 17, 2021
@Reminiscent Reminiscent added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Nov 17, 2021
@Reminiscent
Copy link
Contributor

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Nov 17, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29872

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 17, 2021
@qw4990 @ti-srebot
cherry pick pingcap#29859 to release-5.3
27560e8 
Signed-off-by: ti-srebot <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Nov 18, 2021
@ti-srebot
planner: generate PointGet plans for PlanCache when all conditions ar…
79e237d 
…e EQ (#29859) (#29872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@winoros winoros winoros approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. epic/plan-cache needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8% tpcc performance degradation caused by #29238
5 participants
@qw4990 @ti-chi-bot @Reminiscent @ti-srebot @winoros