-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: disable parallel to avoid data race when test #29739
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
7e1e633
to
a5a9f2f
Compare
/run-check_dev_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you indicate in the description where data race occurs?
Yes, I have added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to follow the practice in #26022
When test cases should be run in serial at the top level, move them into
xxx_serial_test.go
file.
otherwise, it decreases the readability of code.
0233f47
to
5bf5970
Compare
1e70ef4
to
044ed2e
Compare
I have fixed. |
193326e
to
60ea6ae
Compare
Signed-off-by: Weizhen Wang <[email protected]>
60ea6ae
to
36b9f72
Compare
@tisonkun @Defined2014 PTAL |
@Defined2014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 36b9f72
|
@hawkingrei: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Weizhen Wang [email protected]
What problem does this PR solve?
Problem Summary:
statistics: disable parallel to avoid data race when test.
many tests will change
domain.RunAutoAnalyze
that lead to a data race.Check List
Tests
Release note