Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix create binding panic when status.record-db-qp enable #29519

Merged
merged 6 commits into from
Nov 8, 2021
Merged

planner: fix create binding panic when status.record-db-qp enable #29519

merged 6 commits into from
Nov 8, 2021

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Nov 5, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #29503

Problem Summary:

  1. We forget to check the nil for ast.SelectStmt.From. When we create the empty table query, it will cause panic. E.g, select 1.
  2. We forget to assign tableInfo and dbInfo to ast.StmtNode when we create the binding and the config record-db-qps enable.
  3. We forget to check the nil in getStmtDbLabel function for *ast.CreateBindingStmt, it will cause panic when the table is empty.

What is changed and how it works?

  1. Check the nil for ast.SelectStmt.From.
  2. Assign tableInfo and dbInfo to ast.StmtNode when we create the binding and the config record-db-qps enable.
  3. Check the nil in getStmtDbLabel function for *ast.CreateBindingStmt.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent added the type/bugfix This PR fixes a bug. label Nov 5, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2021
@Reminiscent
Copy link
Contributor Author

/run-all-tests

time-and-fate
time-and-fate reviewed Nov 8, 2021
View reviewed changes
planner/core/preprocess.go
@@ -453,6 +453,10 @@ func (p *preprocessor) checkBindGrammar(originNode, hintedNode ast.StmtNode, def
p.err = ddl.ErrOptOnTemporaryTable.GenWithStackByArgs("create binding")
return
}
tableInfo := tbl.Meta()
dbInfo, _ := p.ensureInfoSchema().SchemaByTable(tableInfo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle this error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second return value is not an error. It means whether we can find the table. We have already checked this.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2021
@qw4990
Copy link
Contributor

qw4990 commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c54e43f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@Reminiscent
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 7feb0e6 into pingcap:master Nov 8, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 8, 2021
@Reminiscent @ti-srebot
cherry pick pingcap#29519 to release-5.3
4202a9a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Nov 8, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29574

@Reminiscent Reminiscent deleted the issue#29503 branch November 8, 2021 14:51
ti-chi-bot pushed a commit that referenced this pull request Nov 9, 2021
@ti-srebot
planner: fix create binding panic when status.record-db-qp enable (#2…
74b5157 
…9519) (#29574)
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 3, 2021
@Reminiscent @ti-srebot
cherry pick pingcap#29519 to release-5.2
0eb4a35 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #30371

@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 3, 2021
@Reminiscent @ti-srebot
cherry pick pingcap#29519 to release-5.0
a2ad57f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #30372

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 3, 2021
@Reminiscent @ti-srebot
cherry pick pingcap#29519 to release-5.1
c5e3f9a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #30373

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 3, 2021
@Reminiscent @ti-srebot
cherry pick pingcap#29519 to release-4.0
e72cf30 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #30374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
epic/sql-plan-management needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create binding cause connection panic
5 participants
@Reminiscent @ti-chi-bot @qw4990 @ti-srebot @time-and-fate