Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: support batch create table for restore #29380

Merged
merged 239 commits into from
Jan 17, 2022
Merged

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Nov 3, 2021

What problem does this PR solve?

Issue Number: close #30284
PR only for BR part review, the TiDB review please refer to: #28763

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

fengou1 and others added 30 commits September 27, 2021 19:33
Signed-off-by: xhe <[email protected]>
Co-authored-by: Arenatlx <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
@fengou1
Copy link
Contributor Author

fengou1 commented Jan 14, 2022

/run-check_dev_2

@fengou1
Copy link
Contributor Author

fengou1 commented Jan 14, 2022

/run-mysql-test

@fengou1
Copy link
Contributor Author

fengou1 commented Jan 14, 2022

/run-unit-test

@hawkingrei
Copy link
Member

/run-mysql-test

@fengou1
Copy link
Contributor Author

fengou1 commented Jan 15, 2022

I had a try to debug the failure, pull this latest branch into local and make br_unit_test, I get all UT passed.

@fengou1
Copy link
Contributor Author

fengou1 commented Jan 15, 2022

/run-unit-test

@fengou1
Copy link
Contributor Author

fengou1 commented Jan 15, 2022

/run-check_dev_2

1 similar comment
@fengou1
Copy link
Contributor Author

fengou1 commented Jan 15, 2022

/run-check_dev_2

@fengou1
Copy link
Contributor Author

fengou1 commented Jan 15, 2022

it looks tidb UT panic caused by this PR, will double check the UT and fix it asap.

… optimize even dbpool is 0, however it require tidb change. Will create a new PR for next step optimization.
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 15, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec578f0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
@fengou1
Copy link
Contributor Author

fengou1 commented Jan 17, 2022

/run-unit-test

1 similar comment
@fengou1
Copy link
Contributor Author

fengou1 commented Jan 17, 2022

/run-unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BR using new TiDB ddl api to create tables
8 participants