Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling: optimize dumpling log level #29341

Merged
merged 8 commits into from
Nov 4, 2021
Merged

dumpling: optimize dumpling log level #29341

merged 8 commits into from
Nov 4, 2021

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Some dumpling's log are too frightening but they don't actually affect the dump process.

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Revert some log level from Error -> Warn and some from Warn to Info.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 2, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 2, 2021
@lichunzhu lichunzhu requested review from okJiang and Ehco1996 November 2, 2021 06:46
@lichunzhu lichunzhu added the component/dumpling This is related to Dumpling of TiDB. label Nov 2, 2021
@ti-chi-bot
Copy link
Member

@okJiang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Ehco1996
Ehco1996 reviewed Nov 2, 2021
View reviewed changes
dumpling/export/sql.go Outdated Show resolved Hide resolved
dumpling/export/dump.go Show resolved Hide resolved
dumpling/export/dump.go Outdated Show resolved Hide resolved
dumpling/export/dump.go Outdated Show resolved Hide resolved
Ehco1996
Ehco1996 approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2021
@lichunzhu
Copy link
Contributor Author

/rebuild

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d252569

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2021
@ti-chi-bot ti-chi-bot merged commit fb5b3a0 into pingcap:master Nov 4, 2021
@lichunzhu lichunzhu deleted the fixDumplingErrorMsg branch November 4, 2021 12:43
@lichunzhu lichunzhu added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Nov 4, 2021
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-5.3

@lichunzhu
Copy link
Contributor Author

/cherry-pick 5.3

@lichunzhu lichunzhu added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 and removed needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Nov 5, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 5, 2021
Merged
2 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 5, 2021
@lichunzhu @ti-srebot
cherry pick pingcap#29341 to release-5.3
b78d96a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29488

ti-chi-bot pushed a commit that referenced this pull request Nov 5, 2021
@ti-srebot
dumpling: optimize dumpling log level (#29341) (#29488)
4760e4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@okJiang okJiang okJiang approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
component/dumpling This is related to Dumpling of TiDB. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lichunzhu @ti-chi-bot @ti-srebot @glorv @okJiang @Ehco1996