builtin: add random-bytes function #2927
Conversation
|
@bom-d-van |
plan/typeinferer_test.go
Outdated
| @@ -249,6 +249,7 @@ func (ts *testTypeInferrerSuite) TestInferType(c *C) { | |||
| {`sha1(123)`, mysql.TypeVarString, "utf8"}, | |||
| {`sha(123)`, mysql.TypeVarString, "utf8"}, | |||
| {`sha2(123, 256)`, mysql.TypeVarString, charset.CharsetUTF8}, | |||
| {`random_bytes(32)`, mysql.TypeInt24, charset.CharsetBin}, | |||
There was a problem hiding this comment.
Should be mysql.TypeVarString, charset.CharsetBin.
|
@bom-d-van |
|
@coocood Sorry for that, it should be alright now. Thanks! |
|
LGTM |
coocood
added
status/LGT1
| f, err = fc.getFunction(datumsToConstants([]types.Datum{types.NewDatum(1025)}), s.ctx) | ||
| c.Assert(err, IsNil) | ||
| _, err = f.eval(nil) | ||
| c.Assert(err, Not(IsNil)) |
There was a problem hiding this comment.
You can use NotNil instead of Not(IsNil).
| return d, nil | ||
| } | ||
| size := arg.GetInt64() | ||
| if size < 1 || size > 1024 { |
There was a problem hiding this comment.
MySQL returns the following error code and error message
"mysql> select RANDOM_BYTES(2048);
ERROR 1690 (22003): length value is out of range in 'random_bytes'"
Please use standard error code or add a TODO comment here (Then we will fix it latter.).
There was a problem hiding this comment.
I have changed it as you suggested. Thanks. :)
|
LGTM |
No description provided.