Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning_web: update npm (#28702) #28707

Merged
merged 3 commits into from
Oct 14, 2021
Merged

lightning_web: update npm (#28702) #28707

merged 3 commits into from
Oct 14, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Oct 11, 2021 •
edited
Loading

cherry-pick #28702 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/28707

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/28707:release-5.2-dbfc28239b12

What problem does this PR solve?

Problem Summary: update npm package to avoid security report.

What is changed and how it works?

What's Changed:
run npm update in br/web

Check List

Tests

  • No code

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 11, 2021
@ti-srebot ti-srebot mentioned this pull request Oct 11, 2021
Merged
1 task
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. type/5.2-cherry-pick labels Oct 11, 2021
@ti-srebot
Copy link
Contributor Author

@3pointer you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2021
@3pointer
Copy link
Contributor

/run-check-dev

@3pointer
Copy link
Contributor

/run-check_dev

1 similar comment
@3pointer
Copy link
Contributor

/run-check_dev

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 13, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 30471d1d7b978a47ef6a19d01881873ea270f068

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 13, 2021
@3pointer 3pointer force-pushed the release-5.2-dbfc28239b12 branch from 2b582b1 to 16b7ccc Compare October 14, 2021 02:25
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 14, 2021
@glorv
Copy link
Contributor

glorv commented Oct 14, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 16b7ccc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2021
@glorv
Copy link
Contributor

glorv commented Oct 14, 2021

/run-check_dev

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor

glorv commented Oct 14, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 873ba89 into pingcap:release-5.2 Oct 14, 2021
@glorv glorv deleted the release-5.2-dbfc28239b12 branch October 14, 2021 05:09
@zhouqiang-cl zhouqiang-cl added this to the v5.2.2 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@kennytm kennytm kennytm approved these changes

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees

@3pointer 3pointer

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @3pointer @zhouqiang-cl @glorv @kennytm