Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: not push invalid cast to tiflash #28458

Merged
merged 10 commits into from
Oct 8, 2021
Merged

expression: not push invalid cast to tiflash #28458

merged 10 commits into from
Oct 8, 2021

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #23907

Problem Summary:
As the issue described.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

The root cause of this error is for cast function like castIntAsInt, TiDB's implementation is castIntAsInt64, so in order to be consistent with TiDB, TiFlash's cast only support cast something to Int64. However, the return type of castIntAsInt is not always Int64, if the return type is Int32, TiFlash will try to cast something to Int32, this will cause TiFlash throw tidb_cast to Int32 is not supported error. This pr check the return type of cast function, and only allow it to be pushed down to TiFlash if supported.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

Fix unexpected error like `tidb_cast to Int32 is not supported` when unsupported cast is pushed down to TiFlash

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2021
@windtalker windtalker force-pushed the not_push_invalid_cast_to_tiflash branch from e82998a to 0e1e209 Compare September 28, 2021 09:05
fzhedu
fzhedu reviewed Sep 29, 2021
View reviewed changes
expression/expression.go Outdated
Comment on lines 1053 to 1054
case tipb.ScalarFuncSig_CastDecimalAsInt /*, tipb.ScalarFuncSig_CastDurationAsInt*/, tipb.ScalarFuncSig_CastIntAsInt, tipb.ScalarFuncSig_CastRealAsInt,
tipb.ScalarFuncSig_CastTimeAsInt, tipb.ScalarFuncSig_CastStringAsInt /*, tipb.ScalarFuncSig_CastJsonAsInt*/ :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collect together the unsupported cases?

@windtalker windtalker force-pushed the not_push_invalid_cast_to_tiflash branch from 0e1e209 to 34795c4 Compare September 29, 2021 03:33
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2021
@windtalker windtalker force-pushed the not_push_invalid_cast_to_tiflash branch from 34795c4 to c99cf1f Compare September 29, 2021 03:43
fzhedu
fzhedu approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2021
@windtalker
Copy link
Contributor Author

/label needs-cherry-pick-5.2

@windtalker
Copy link
Contributor Author

/label needs-cherry-pick-5.1

@windtalker
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@windtalker windtalker force-pushed the not_push_invalid_cast_to_tiflash branch 2 times, most recently from af1efec to 52175ba Compare September 29, 2021 07:16
@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@windtalker
Copy link
Contributor Author

/run-check_title

lzmhhh123
lzmhhh123 reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

expression/expression.go Outdated
Comment on lines 1071 to 1076
/*case tipb.ScalarFuncSig_CastDecimalAsDuration, tipb.ScalarFuncSig_CastDurationAsDuration, tipb.ScalarFuncSig_CastIntAsDuration, tipb.ScalarFuncSig_CastRealAsDuration,
tipb.ScalarFuncSig_CastTimeAsDuration, tipb.ScalarFuncSig_CastStringAsDuration, tipb.ScalarFuncSig_CastJsonAsDuration:
return true*/
/*case tipb.ScalarFuncSig_CastDecimalAsJson, tipb.ScalarFuncSig_CastDurationAsJson, tipb.ScalarFuncSig_CastIntAsJson, tipb.ScalarFuncSig_CastRealAsJson,
tipb.ScalarFuncSig_CastTimeAsJson, tipb.ScalarFuncSig_CastStringAsJson, tipb.ScalarFuncSig_CastJsonAsJson:
return true*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it.

@windtalker windtalker force-pushed the not_push_invalid_cast_to_tiflash branch from 52175ba to 40f6559 Compare October 8, 2021 06:36
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 40f6559

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@windtalker
Copy link
Contributor Author

/run_check_dev_2

1 similar comment
@windtalker
Copy link
Contributor Author

/run_check_dev_2

@windtalker
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 36d0b40 into pingcap:master Oct 8, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 8, 2021
@windtalker @ti-srebot
cherry pick pingcap#28458 to release-5.0
bae1483 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #28651

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 8, 2021
@windtalker @ti-srebot
cherry pick pingcap#28458 to release-5.1
6800523 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #28652

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 8, 2021
@windtalker @ti-srebot
cherry pick pingcap#28458 to release-5.2
940cb5b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28654

ti-chi-bot pushed a commit that referenced this pull request Oct 14, 2021
@ti-srebot
expression: not push invalid cast to tiflash (#28458) (#28654)
30c970e
@windtalker windtalker deleted the not_push_invalid_cast_to_tiflash branch November 16, 2021 01:24
ti-chi-bot pushed a commit that referenced this pull request Dec 20, 2021
@ti-srebot
expression: not push invalid cast to tiflash (#28458) (#28651)
7fae4e7 
close #23907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@fzhedu fzhedu fzhedu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR 1105 (HY000): tidb_cast to Int32 is not supported
6 participants
@windtalker @ti-chi-bot @sre-bot @lzmhhh123 @ti-srebot @fzhedu