-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: make infer collation support the expressions with different charset #27863
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
d6b704a
to
0d1d9ee
Compare
b4d2017
to
2f6c39b
Compare
2f6c39b
to
44b7ea0
Compare
ae37137
to
327ccf3
Compare
327ccf3
to
38ea901
Compare
38ea901
to
50e5038
Compare
50e5038
to
72d20e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d4833d4
to
52f1ab0
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fa0c3b9
|
@xiongjiwei: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary:
ExprCollation
, it holds all the collation-related information to avoid function return to many values.repertoire
field intocollationInfo
, see https://dev.mysql.com/doc/refman/8.0/en/charset-repertoire.html.inferCollation
logic, make it totally same withDTCollation::aggregate
in MySQL.safeConvert
after inferring collation to check if all the arguments can convert their charset to the derived charset safelythis PR changes a lot, but most of them are simply replace, reviewers should force on
expression/collation.go
Check List
Tests
Side effects
Documentation
Release note