Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix the security report from github #27729

Merged
merged 7 commits into from
Sep 2, 2021
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Sep 1, 2021

What problem does this PR solve?

Problem Summary: close #26983
After BR merged into tidb. lightning/web introduced node pkg which has some warning report from github.

What is changed and how it works?

What's Changed:
use npm to update package-lock.json

Check List

Tests

  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2021
@3pointer 3pointer requested a review from kennytm September 1, 2021 10:00
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 1, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2021
@3pointer
Copy link
Contributor Author

3pointer commented Sep 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a5212ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2021
@3pointer
Copy link
Contributor Author

3pointer commented Sep 2, 2021

/run-check_dev_2

@kennytm
Copy link
Contributor

kennytm commented Sep 2, 2021

/run-check_dev_2

these hard limits very annoying 💢

[2021-09-02T06:30:44.703Z] The following test cases take too long to finish:

[2021-09-02T06:30:44.703Z] PASS: db_test.go:573: testDBSuite7.TestCancelAddIndex	7.406s

[2021-09-02T06:30:44.703Z] PASS: db_integration_test.go:1352: testIntegrationSuite6.TestCreateTableTooLarge	7.852s

[2021-09-02T06:30:44.703Z] PASS: db_partition_test.go:632: testIntegrationSuite1.TestCreateTableWithListPartition	8.394s

[2021-09-02T06:30:44.703Z] PASS: db_test.go:1201: testDBSuite3.TestAddPrimaryKey3	5.182s

[2021-09-02T06:30:44.703Z] PASS: db_test.go:557: testDBSuite8.TestCancelAddPrimaryKey	9.668s

[2021-09-02T06:30:44.703Z] PASS: db_partition_test.go:2681: testIntegrationSuite4.TestPartitionCancelAddIndex	5.734s

[2021-09-02T06:30:44.703Z] PASS: partition_table_test.go:2955: testSuiteWithData.TestRangePartitionBoundariesBetweenM	5.174s

[2021-09-02T06:30:44.703Z] PASS: analyze_test.go:170: testSuite1.TestAnalyzeParameters	6.720s

[2021-09-02T06:30:44.703Z] PASS: partition_table_test.go:3021: testSuiteWithData.TestRangePartitionBoundariesLtS	5.227s

[2021-09-02T06:30:44.703Z] PASS: builtin_string_vec_test.go:529: testVectorizeSuite1.TestVectorizedBuiltinStringEvalOneVec	5.944s

[2021-09-02T06:30:44.703Z] PASS: builtin_time_vec_generated_test.go:6727: testVectorizeSuite1.TestVectorizedBuiltinTimeEvalOneVecGenerated	5.039s

@ti-chi-bot ti-chi-bot merged commit deb613f into pingcap:master Sep 2, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot alerts introduced by merge BR into TiDB
5 participants