Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: make group_concat function consider the collation #27490

Merged
merged 4 commits into from
Aug 24, 2021
Merged

executor: make group_concat function consider the collation #27490

merged 4 commits into from
Aug 24, 2021

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27429

make group_concat function consider the collation

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

make `group_concat` function consider the collation

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • ichn-hu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2021
@xiongjiwei xiongjiwei requested review from SunRunAway, a team and XuHuaiyu and removed request for a team August 23, 2021 06:32
@github-actions github-actions bot added the sig/execution SIG execution label Aug 23, 2021
@xiongjiwei xiongjiwei requested a review from wjhuang2016 August 23, 2021 07:02
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133 bb7133 added sig/sql-infra SIG: SQL Infra and removed sig/execution SIG execution labels Aug 23, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a4e55bc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 23, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 23, 2021

/run-check_dev_2

1 similar comment
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei
Copy link
Contributor Author

/merge

1 similar comment
@bb7133
Copy link
Member

bb7133 commented Aug 24, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit d9bf3bf into pingcap:master Aug 24, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27490 to release-5.0
6242b42 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27528

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27490 to release-5.1
eb9c524 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27529

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27490 to release-5.2
b4d8965 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27530

ti-chi-bot pushed a commit that referenced this pull request Sep 3, 2021
@ti-srebot
executor: make group_concat function consider the collation (#27490) (
7bdcf69 
#27528)
@ti-srebot ti-srebot mentioned this pull request Sep 6, 2021
Merged
12 tasks
@xiongjiwei
Copy link
Contributor Author

/cherry-pick

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27835

xiongjiwei added a commit to ti-srebot/tidb that referenced this pull request Sep 6, 2021
@xiongjiwei
cherry pick pingcap#27490 to release-4.0
95efbde 
Signed-off-by: ti-srebot <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Sep 8, 2021
@ti-srebot
executor: make group_concat function consider the collation (#27490) (
1881af7 
#27835)
ti-chi-bot pushed a commit that referenced this pull request Sep 14, 2021
@ti-srebot
executor: make group_concat function consider the collation (#27490) (
88689b4 
#27529)
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
ti-chi-bot pushed a commit that referenced this pull request Oct 13, 2021
@ti-srebot
executor: make group_concat function consider the collation (#27490) (
7cd215c 
#27530)
@xiongjiwei xiongjiwei deleted the group_concat branch September 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@bb7133 bb7133 bb7133 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group_concat() does not consider collatioin resulting errors
5 participants
@xiongjiwei @ti-chi-bot @bb7133 @ti-srebot @ichn-hu