planner: ban baseline evolution feature #26333

Reminiscent · 2021-07-19T06:44:11Z

What problem does this PR solve?

Issue Number: close issue#26330

Problem Summary:
Ban the baseline evolution feature before the feature is GA.

What is changed and how it works?

When we set the system variable tidb_evolve_plan_baselines it will report an error.
When we execute admin evolve bindings, it will report an error.

Check List

Tests

Unit test

Documentation

Affects user behaviors

Release note

Ban baseline evolution feature until the feature is GA.

…aselineEvolution

ti-chi-bot · 2021-07-19T06:44:12Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

eurekaka
qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Reminiscent · 2021-07-19T06:44:28Z

/label sig/planner

ti-chi-bot · 2021-07-19T06:44:29Z

@Reminiscent: The label(s) sig/planner cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label sig/planner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Reminiscent · 2021-07-19T06:46:52Z

/cc @eurekaka

Reminiscent · 2021-07-19T06:59:20Z

/rebuild

…aselineEvolution

eurekaka · 2021-08-02T07:07:02Z

/label epic/sql-plan-management

ti-chi-bot · 2021-08-02T07:07:04Z

@eurekaka: The label(s) epic/sql-plan-management cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label epic/sql-plan-management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

eurekaka · 2021-08-03T07:46:43Z

executor/set.go

@@ -108,6 +109,10 @@ func (e *SetExecutor) setSysVariable(ctx context.Context, name string, v *expres
 	if sysVar == nil {
 		return variable.ErrUnknownSystemVar.GenWithStackByArgs(name)
 	}
+	// The 'baseline evolution' only work in the CI environment before the feature is GA.
+	if sysVar.Name == "tidb_evolve_plan_baselines" && !config.CheckTableBeforeDrop {


We should check the target value is on before reporting error, otherwise, if the users have already enabled this feature, they cannot disable the feature anymore.

eurekaka · 2021-08-03T07:49:26Z

executor/set.go

@@ -108,6 +109,10 @@ func (e *SetExecutor) setSysVariable(ctx context.Context, name string, v *expres
 	if sysVar == nil {
 		return variable.ErrUnknownSystemVar.GenWithStackByArgs(name)
 	}
+	// The 'baseline evolution' only work in the CI environment before the feature is GA.
+	if sysVar.Name == "tidb_evolve_plan_baselines" && !config.CheckTableBeforeDrop {
+		return errors.Errorf("The 'baseline evolution' of TiDB has not been GA yet, so it is forbidden to use it.")


Suggested change

return errors.Errorf("The 'baseline evolution' of TiDB has not been GA yet, so it is forbidden to use it.")

return errors.Errorf("Cannot enable baseline evolution feature, it is not generally available now")

…aselineEvolution

…ent/tidb into forbidBaselineEvolution

Reminiscent · 2021-08-03T10:15:44Z

@eurekaka Update. PTAL

qw4990 · 2021-08-04T06:56:56Z

session/session.go

@@ -1143,6 +1143,9 @@ func (s *session) SetGlobalSysVar(name, value string) (err error) {
 	if value, err = sv.Validate(s.sessionVars, value, variable.ScopeGlobal); err != nil {
 		return err
 	}
+	if sv.Name == "tidb_evolve_plan_baselines" && strings.EqualFold("ON", value) && !config.CheckTableBeforeDrop {


And are sv.Name and value standardized here? What if tidb_EVOLVE_plan_baselines or on?

…aselineEvolution

Reminiscent · 2021-08-04T13:14:31Z

/merge

ti-chi-bot · 2021-08-04T13:14:34Z

This pull request has been accepted and is ready to merge.

Commit hash: 0a8ef1e

Reminiscent · 2021-08-04T14:04:10Z

/run-all-tests

Reminiscent · 2021-08-04T14:13:31Z

/run-all-tests

…ent/tidb into forbidBaselineEvolution

Reminiscent · 2021-08-05T01:35:38Z

/merge

ti-chi-bot · 2021-08-05T01:35:42Z

This pull request has been accepted and is ready to merge.

Commit hash: 9c6f681

ti-chi-bot · 2021-08-05T01:36:37Z

@Reminiscent: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Reminiscent added 3 commits July 19, 2021 14:39

planner: ban baseline evolution feature

a8443d3

Merge branch 'master' of https://github.com/pingcap/tidb into forbidB…

9655712

…aselineEvolution

fix format

527ccd9

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2021

github-actions bot added sig/execution SIG execution sig/planner SIG: Planner labels Jul 19, 2021

ti-chi-bot requested a review from eurekaka July 19, 2021 06:46

Reminiscent added 4 commits July 20, 2021 10:30

fix ut

021f123

Merge branch 'master' of https://github.com/pingcap/tidb into forbidB…

9c957bf

…aselineEvolution

fixup

f6b3c30

Merge branch 'master' of https://github.com/pingcap/tidb into forbidB…

441c767

…aselineEvolution

eurekaka added the epic/sql-plan-management label Aug 2, 2021

Merge branch 'master' into forbidBaselineEvolution

197ace0

Reminiscent mentioned this pull request Aug 2, 2021

update doc for SPM pingcap/docs-cn#6790

Merged

12 tasks

eurekaka reviewed Aug 3, 2021

View reviewed changes

Reminiscent added 3 commits August 3, 2021 18:06

address comments

13842bd

Merge branch 'master' of https://github.com/pingcap/tidb into forbidB…

34b8184

…aselineEvolution

Merge branch 'forbidBaselineEvolution' of https://github.com/Reminisc…

0ee830b

…ent/tidb into forbidBaselineEvolution

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2021

github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 3, 2021

Reminiscent requested a review from eurekaka August 4, 2021 02:03

qw4990 reviewed Aug 4, 2021

View reviewed changes

eurekaka approved these changes Aug 4, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021

Reminiscent added 2 commits August 4, 2021 16:09

address comments

5756178

Merge branch 'master' of https://github.com/pingcap/tidb into forbidB…

98ba826

…aselineEvolution

qw4990 approved these changes Aug 4, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021

Merge branch 'master' into forbidBaselineEvolution

0a8ef1e

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021

Merge branch 'master' into forbidBaselineEvolution

eae9ae7

ti-chi-bot and others added 5 commits August 5, 2021 02:27

Merge branch 'master' into forbidBaselineEvolution

0259d4a

Merge branch 'master' into forbidBaselineEvolution

3f0e4b2

Merge branch 'master' into forbidBaselineEvolution

68a0b01

fix ut

af6a7e3

Merge branch 'forbidBaselineEvolution' of https://github.com/Reminisc…

9c6f681

…ent/tidb into forbidBaselineEvolution

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021

Merge branch 'master' into forbidBaselineEvolution

c5738c9

ti-chi-bot merged commit bfbe67d into pingcap:master Aug 5, 2021

Reminiscent deleted the forbidBaselineEvolution branch August 5, 2021 01:55

morgo mentioned this pull request Aug 9, 2021

session, variable: cleanup TiDBEvolvePlanBaselines sysvar validation #27004

Merged

12 tasks

Reminiscent mentioned this pull request Aug 16, 2021

spm: add upgrade checklist for SPM pingcap/docs-cn#6866

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: ban baseline evolution feature #26333

planner: ban baseline evolution feature #26333

Reminiscent commented Jul 19, 2021 •

edited

Loading

ti-chi-bot commented Jul 19, 2021 •

edited

Loading

Reminiscent commented Jul 19, 2021

ti-chi-bot commented Jul 19, 2021

Reminiscent commented Jul 19, 2021

Reminiscent commented Jul 19, 2021

eurekaka commented Aug 2, 2021

ti-chi-bot commented Aug 2, 2021

eurekaka Aug 3, 2021

eurekaka Aug 3, 2021

Reminiscent commented Aug 3, 2021

qw4990 Aug 4, 2021

Reminiscent commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

Reminiscent commented Aug 4, 2021

Reminiscent commented Aug 4, 2021

Reminiscent commented Aug 5, 2021

ti-chi-bot commented Aug 5, 2021

ti-chi-bot commented Aug 5, 2021

	return errors.Errorf("The 'baseline evolution' of TiDB has not been GA yet, so it is forbidden to use it.")
	return errors.Errorf("Cannot enable baseline evolution feature, it is not generally available now")

planner: ban baseline evolution feature #26333

planner: ban baseline evolution feature #26333

Conversation

Reminiscent commented Jul 19, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jul 19, 2021 • edited Loading

Reminiscent commented Jul 19, 2021

ti-chi-bot commented Jul 19, 2021

Reminiscent commented Jul 19, 2021

Reminiscent commented Jul 19, 2021

eurekaka commented Aug 2, 2021

ti-chi-bot commented Aug 2, 2021

eurekaka Aug 3, 2021

Choose a reason for hiding this comment

eurekaka Aug 3, 2021

Choose a reason for hiding this comment

Reminiscent commented Aug 3, 2021

qw4990 Aug 4, 2021

Choose a reason for hiding this comment

Reminiscent commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

Reminiscent commented Aug 4, 2021

Reminiscent commented Aug 4, 2021

Reminiscent commented Aug 5, 2021

ti-chi-bot commented Aug 5, 2021

ti-chi-bot commented Aug 5, 2021

Reminiscent commented Jul 19, 2021 •

edited

Loading

ti-chi-bot commented Jul 19, 2021 •

edited

Loading