-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix user without process privilege can access cluster_tidb_trx #26255
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also fixed:
CLUSTER_SYSTEMINFO, CLUSTER_HARDWARE and CLUSTER_LOAD, or is that just from a previous patch?
…oad, Hardware Signed-off-by: ailinkid <[email protected]>
Signed-off-by: ailinkid <[email protected]>
Signed-off-by: ailinkid <[email protected]>
5d8c4ef
to
65a718e
Compare
In our design |
Misunderstood before. Maybe the designer see a user without PROCESS privilege get access to this even though it gets empty result set. |
This actually referenced the processlist table:
It's a problem that this behavior seems to lack of test coverage. cc @longfangsong |
What problem does this PR solve?
Issue Number: close #26127
What is changed and how it works?
*: What's Changed: add the privileges check when read the memory table
Check List
Tests
Documentation
Release note