-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, privilege: require CONFIG or Process privilege for is.cluster_* #26220
Conversation
And testing different case of table names...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current patch breaks the telemetry test, due to lack of Process
privileges for i_s.cluster_info table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@morgo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b1b06e9
|
/run-unit-test |
cherry pick to release-5.1 in PR #26297 |
…or is.cluster_* (pingcap#26220) Signed-off-by: ailinkid <[email protected]>
What problem does this PR solve?
Issue Number: close #26121,#26122,#26123,#26124,#26126
Problem Summary:
The information_schema.cluster_* tables should require the
CONFIG
orProcess
privilege. This is consistent with the behavior change in #25379 which requires CONFIG for SHOW CONFIG.It makes sense to cherry pick to 5.1, but not 5.0; because the behavior in 5.0 was not established yet, and SHOW CONFIG still requires no privileges.
What is changed and how it works?
What's Changed:
Reading from the table information_schema.cluster_hardware now requires the CONFIG privilege.
Reading from the table information_schema.cluster_{info,load,systeminfo,log} now requires the CONFIG privilege.
Check List
Tests
Side effects
Release note
Process
privilege.Process
privilege.Process
privilege.Process
privilege.