Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: garbage collect deleted bind records #26206

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Jul 13, 2021

What problem does this PR solve?

Issue Number: close #26191

Problem Summary:

GC bind record with deleted status.

What is changed and how it works?

What's Changed:

  • add a ticker to trigger the gc in the background loop
  • expose bind owner, and only do gc in bind owner

Check List

Tests

  • Unit test
  • Manual test: start 2 tidb servers, and create / drop a global binding on one tidb, then observe the results of show global bindings and select * from mysql.bind_info on 2 tidb servers. Check that, the "deleted" bind record in mysql.bind_info is removed after 5.5 minutes.

Side effects

N/A

Documentation

N/A

Release note

  • Garbage collect deleted bind records

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner epic/sql-plan-management labels Jul 13, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 13, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Aug 4, 2021

/rebuild

@eurekaka
Copy link
Contributor Author

eurekaka commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a603a54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021
@winoros
Copy link
Member

winoros commented Aug 4, 2021

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/sql-plan-management sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC bind record with deleted status
5 participants