expression: optimize localSliceBuffer to be lock-free #26078

wzru · 2021-07-09T03:57:48Z

What problem does this PR solve?

Problem Summary:

lock makes localSliceBuffer slow

What is changed and how it works?

What's Changed:

localSliceBuffer implementation

How it Works:

use lock-free sync.Pool

Related changes

Check List

Tests

Integration test

Side effects

Performance regression
- Consumes less CPU

Summary of benchmark (ns/op):

	Get	GetParaller	GetPut	GetPutParallel
before	473667	332444	32537	326075
after	432685	131679	48197	6762
rate	1.09	2.52	0.68	48.22

Release note

No release note

mmyj · 2021-07-10T17:02:32Z

Please add a benchmark result of this optimize.

Signed-off-by: WangZhengru <[email protected]>

wzru · 2021-07-13T08:12:04Z

BenchmarkColumnBufferAllocateParallel
before vs after:

BenchmarkColumnBufferAllocateParallel-16    	    3872	    348108 ns/op	       3 B/op	       0 allocs/op
BenchmarkColumnBufferAllocateParallel-16    	  195615	      6916 ns/op	       0 B/op	       0 allocs/op

BenchmarkColumnBufferAllocate
before vs after:

BenchmarkColumnBufferAllocate-16    	   26558	     40542 ns/op	       0 B/op	       0 allocs/op
BenchmarkColumnBufferAllocate-16    	   24264	     49455 ns/op	       0 B/op	       0 allocs/op

wzru · 2021-07-13T08:12:43Z

/cc @guo-shaoge

Signed-off-by: WangZhengru <[email protected]>

wzru · 2021-07-13T08:34:58Z

/run-check_dev_2

wzru · 2021-07-13T08:41:49Z

/cc @lzmhhh123

guo-shaoge · 2021-07-13T08:50:31Z

@mmyj BenchmarkColumnBufferAllocateParallel
before vs after:

BenchmarkColumnBufferAllocateParallel-16    	    3872	    348108 ns/op	       3 B/op	       0 allocs/op
BenchmarkColumnBufferAllocateParallel-16    	  195615	      6916 ns/op	       0 B/op	       0 allocs/op

Result of BenchmarkColumnBufferAllocate may also need.

wzru · 2021-07-13T09:00:25Z

@mmyj BenchmarkColumnBufferAllocateParallel
before vs after:
BenchmarkColumnBufferAllocateParallel-16    	    3872	    348108 ns/op	       3 B/op	       0 allocs/op
BenchmarkColumnBufferAllocateParallel-16    	  195615	      6916 ns/op	       0 B/op	       0 allocs/op
Result of BenchmarkColumnBufferAllocate may also need.

updated

expression/builtin_vectorized_test.go

expression/builtin_vectorized.go

Signed-off-by: WangZhengru <[email protected]>

guo-shaoge · 2021-07-15T06:52:26Z

Most usage of column pool is like GetPutParallel(check the implementation of any vectorized expression), the performance improve is huge. So it looks good to me.

guo-shaoge · 2021-07-15T06:53:50Z

/run-integration-common-test
/run-common-test
/run-integration-copr-test

ti-chi-bot · 2021-07-15T06:54:14Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

guo-shaoge
mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

expression/builtin_vectorized_test.go

Signed-off-by: WangZhengru <[email protected]>

lzmhhh123 · 2021-07-15T13:39:53Z

/merge

ti-chi-bot · 2021-07-15T13:39:56Z

This pull request has been accepted and is ready to merge.

Commit hash: 0a4a8c5

Signed-off-by: WangZhengru <[email protected]>

mmyj · 2021-07-16T04:53:28Z

/merge

ti-chi-bot · 2021-07-16T04:53:31Z

This pull request has been accepted and is ready to merge.

Commit hash: e8f4da4

mmyj · 2021-07-16T05:03:40Z

[2021-07-16T04:59:53.499Z] ==================
[2021-07-16T04:59:53.499Z] WARNING: DATA RACE
[2021-07-16T04:59:53.499Z] Read at 0x00c00c56d5e8 by goroutine 142:
[2021-07-16T04:59:53.499Z]   github.com/pingcap/parser/types.(*FieldType).EvalType()
[2021-07-16T04:59:53.499Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/types/field_type.go:96 +0x44
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/statistics.NewHistogram()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/histogram.go:96 +0x80
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/statistics.PseudoTable()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/table.go:688 +0x34c
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).GetPartitionStats()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:514 +0x159
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).GetTableStats()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:506 +0xe12
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).HandleAutoAnalyze()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/update.go:944 +0xde3
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/domain.(*Domain).autoAnalyzeWorker()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:1336 +0x2ea
[2021-07-16T04:59:53.499Z] 
[2021-07-16T04:59:53.499Z] Previous write at 0x00c00c56d5e8 by goroutine 120:
[2021-07-16T04:59:53.499Z]   [failed to restore the stack]
[2021-07-16T04:59:53.499Z] 
[2021-07-16T04:59:53.499Z] Goroutine 142 (running) created at:
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/domain.(*Domain).UpdateTableStatsLoop()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:1170 +0x350
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/session.BootstrapSession()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:2589 +0x653
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/table/tables_test.(*testSuite).SetUpSuite()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/table/tables/tables_test.go:65 +0x15c
[2021-07-16T04:59:53.499Z]   runtime.call16()
[2021-07-16T04:59:53.499Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-07-16T04:59:53.499Z]   reflect.Value.Call()
[2021-07-16T04:59:53.499Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-07-16T04:59:53.499Z]   github.com/pingcap/check.(*suiteRunner).runFixture.func1()
[2021-07-16T04:59:53.499Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:799 +0x1d0
[2021-07-16T04:59:53.499Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-07-16T04:59:53.499Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:739 +0x11d
[2021-07-16T04:59:53.499Z] 
[2021-07-16T04:59:53.499Z] Goroutine 120 (finished) created at:
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/executor.(*ProjectionExec).prepare()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:271 +0xd04
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/executor.(*ProjectionExec).parallelExecute()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:208 +0x5cb
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/executor.(*ProjectionExec).Next()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:181 +0x10d
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/executor.Next()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:286 +0x2a8
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/executor.(*recordSet).Next()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:145 +0x115
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/session.(*execStmtResult).Next()
[2021-07-16T04:59:53.499Z]       <autogenerated>:1 +0x84
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/session.GetRows4Test()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:307 +0x35e
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/session.ResultSetToStringSlice()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:325 +0xba
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).ResultSetToResultWithCtx()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:389 +0xad
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).ResultSetToResult()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:384 +0x566
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustQuery()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:327 +0x571
[2021-07-16T04:59:53.499Z]   github.com/pingcap/tidb/table/tables_test.(*testSuite).TestViewColumns()
[2021-07-16T04:59:53.499Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/table/tables/tables_test.go:740 +0x7b3
[2021-07-16T04:59:53.499Z]   runtime.call16()
[2021-07-16T04:59:53.499Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-07-16T04:59:53.499Z]   reflect.Value.Call()
[2021-07-16T04:59:53.499Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-07-16T04:59:53.500Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:850 +0xb3b
[2021-07-16T04:59:53.500Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:739 +0x11d
[2021-07-16T04:59:53.500Z] ==================
[2021-07-16T04:59:53.500Z] ==================
[2021-07-16T04:59:53.500Z] WARNING: DATA RACE
[2021-07-16T04:59:53.500Z] Read at 0x00c0058c0ab0 by goroutine 142:
[2021-07-16T04:59:53.500Z]   github.com/pingcap/parser/types.(*FieldType).Clone()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/types/field_type.go:63 +0x3b5
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/statistics.NewHistogram()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/histogram.go:100 +0x4d4
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/statistics.PseudoTable()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/table.go:688 +0x34c
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).GetPartitionStats()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:514 +0x159
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).GetTableStats()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:506 +0xe12
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).HandleAutoAnalyze()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/update.go:944 +0xde3
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/domain.(*Domain).autoAnalyzeWorker()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:1336 +0x2ea
[2021-07-16T04:59:53.500Z] 
[2021-07-16T04:59:53.500Z] Previous write at 0x00c0058c0ab0 by goroutine 120:
[2021-07-16T04:59:53.500Z]   [failed to restore the stack]
[2021-07-16T04:59:53.500Z] 
[2021-07-16T04:59:53.500Z] Goroutine 142 (running) created at:
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/domain.(*Domain).UpdateTableStatsLoop()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:1170 +0x350
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/session.BootstrapSession()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:2589 +0x653
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/table/tables_test.(*testSuite).SetUpSuite()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/table/tables/tables_test.go:65 +0x15c
[2021-07-16T04:59:53.500Z]   runtime.call16()
[2021-07-16T04:59:53.500Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-07-16T04:59:53.500Z]   reflect.Value.Call()
[2021-07-16T04:59:53.500Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-07-16T04:59:53.500Z]   github.com/pingcap/check.(*suiteRunner).runFixture.func1()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:799 +0x1d0
[2021-07-16T04:59:53.500Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:739 +0x11d
[2021-07-16T04:59:53.500Z] 
[2021-07-16T04:59:53.500Z] Goroutine 120 (finished) created at:
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/executor.(*ProjectionExec).prepare()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:271 +0xd04
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/executor.(*ProjectionExec).parallelExecute()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:208 +0x5cb
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/executor.(*ProjectionExec).Next()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:181 +0x10d
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/executor.Next()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:286 +0x2a8
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/executor.(*recordSet).Next()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:145 +0x115
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/session.(*execStmtResult).Next()
[2021-07-16T04:59:53.500Z]       <autogenerated>:1 +0x84
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/session.GetRows4Test()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:307 +0x35e
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/session.ResultSetToStringSlice()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:325 +0xba
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).ResultSetToResultWithCtx()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:389 +0xad
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).ResultSetToResult()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:384 +0x566
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustQuery()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:327 +0x571
[2021-07-16T04:59:53.500Z]   github.com/pingcap/tidb/table/tables_test.(*testSuite).TestViewColumns()
[2021-07-16T04:59:53.500Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/table/tables/tables_test.go:740 +0x7b3
[2021-07-16T04:59:53.500Z]   runtime.call16()
[2021-07-16T04:59:53.500Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-07-16T04:59:53.500Z]   reflect.Value.Call()
[2021-07-16T04:59:53.500Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-07-16T04:59:53.500Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:850 +0xb3b
[2021-07-16T04:59:53.500Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-07-16T04:59:53.500Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:739 +0x11d
[2021-07-16T04:59:53.500Z] ==================

wzru · 2021-07-16T05:05:50Z

/run-unit-test

wzru · 2021-07-16T05:13:06Z

@mmyj @lzmhhh123 All tests passed

wzru added 7 commits July 9, 2021 01:04

expression: optimize localSliceBuffer

faa60ef

expression: optimize localSliceBuffer

acfc23c

expression: optimize localSliceBuffer

821af22

expression: benchmark localSliceBuffer

5a3b149

expression: benchmark localSliceBuffer

db057b2

expression: benchmark localSliceBuffer

d421bf1

expression: optimize localSliceBuffer

f5d0b6d

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2021

github-actions bot added the component/expression label Jul 9, 2021

wzru added 3 commits July 13, 2021 15:37

expression: benchmark localSliceBuffer

0ae268c

Signed-off-by: WangZhengru <[email protected]>

expression: optimize localSliceBuffer

786d7ad

Signed-off-by: WangZhengru <[email protected]>

expression: optimize localSliceBuffer

126774c

Signed-off-by: WangZhengru <[email protected]>

ti-chi-bot requested a review from guo-shaoge July 13, 2021 08:12

expression: doc localSliceBuffer

396fd8c

Signed-off-by: WangZhengru <[email protected]>

ti-chi-bot requested a review from lzmhhh123 July 13, 2021 08:41

wzru changed the title ~~expression: optimize localSliceBuffer~~ expression: optimize localSliceBuffer to be lock-free Jul 13, 2021

mmyj reviewed Jul 13, 2021

View reviewed changes

expression/builtin_vectorized_test.go Show resolved Hide resolved

expression/builtin_vectorized.go Outdated Show resolved Hide resolved

expression/builtin_vectorized.go Outdated Show resolved Hide resolved

lzmhhh123 reviewed Jul 14, 2021

View reviewed changes

expression/builtin_vectorized.go Outdated Show resolved Hide resolved

expression: rename to localColumnPool

8cb2428

Signed-off-by: WangZhengru <[email protected]>

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2021

wzru requested a review from lzmhhh123 July 14, 2021 06:23

expression: delete unused argument

51f05da

Signed-off-by: WangZhengru <[email protected]>

guo-shaoge approved these changes Jul 15, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021

mmyj reviewed Jul 15, 2021

View reviewed changes

expression/builtin_vectorized_test.go Outdated Show resolved Hide resolved

expression/builtin_vectorized_test.go Outdated Show resolved Hide resolved

wzru added 2 commits July 15, 2021 16:22

expression: remove unused localColumnPool parameters

8bcbc8f

Signed-off-by: WangZhengru <[email protected]>

expression: remove unused variables BenchmarkColumnPoolGet*

c32f5a7

Signed-off-by: WangZhengru <[email protected]>

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2021

expression: fix generator

0a4a8c5

Signed-off-by: WangZhengru <[email protected]>

lzmhhh123 approved these changes Jul 15, 2021

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021

ti-chi-bot and others added 3 commits July 15, 2021 21:40

Merge branch 'master' into opt-column-allocator

af91b6b

Merge branch 'master' into opt-column-allocator

7a4ba9b

expression: fix merge

e8f4da4

Signed-off-by: WangZhengru <[email protected]>

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021

Merge branch 'master' into opt-column-allocator

26ebab0

ti-chi-bot merged commit 4325eeb into pingcap:master Jul 16, 2021

This was referenced Oct 19, 2021

Delete unused code in expression/builtin_vectorized.go #28951

Closed

Chunk column reuse #28340

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: optimize localSliceBuffer to be lock-free #26078

expression: optimize localSliceBuffer to be lock-free #26078

wzru commented Jul 9, 2021 •

edited

Loading

mmyj commented Jul 10, 2021

wzru commented Jul 13, 2021 •

edited

Loading

wzru commented Jul 13, 2021

wzru commented Jul 13, 2021

wzru commented Jul 13, 2021

guo-shaoge commented Jul 13, 2021

wzru commented Jul 13, 2021

guo-shaoge commented Jul 15, 2021 •

edited

Loading

guo-shaoge commented Jul 15, 2021

ti-chi-bot commented Jul 15, 2021

lzmhhh123 commented Jul 15, 2021

ti-chi-bot commented Jul 15, 2021

mmyj commented Jul 16, 2021

ti-chi-bot commented Jul 16, 2021

mmyj commented Jul 16, 2021

wzru commented Jul 16, 2021

wzru commented Jul 16, 2021

expression: optimize localSliceBuffer to be lock-free #26078

expression: optimize localSliceBuffer to be lock-free #26078

Conversation

wzru commented Jul 9, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

mmyj commented Jul 10, 2021

wzru commented Jul 13, 2021 • edited Loading

wzru commented Jul 13, 2021

wzru commented Jul 13, 2021

wzru commented Jul 13, 2021

guo-shaoge commented Jul 13, 2021

wzru commented Jul 13, 2021

guo-shaoge commented Jul 15, 2021 • edited Loading

guo-shaoge commented Jul 15, 2021

ti-chi-bot commented Jul 15, 2021

lzmhhh123 commented Jul 15, 2021

ti-chi-bot commented Jul 15, 2021

mmyj commented Jul 16, 2021

ti-chi-bot commented Jul 16, 2021

mmyj commented Jul 16, 2021

wzru commented Jul 16, 2021

wzru commented Jul 16, 2021

wzru commented Jul 9, 2021 •

edited

Loading

wzru commented Jul 13, 2021 •

edited

Loading

guo-shaoge commented Jul 15, 2021 •

edited

Loading