Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix incompatible last_day func behavior in sql mode #25953

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 [email protected]

What problem does this PR solve?

Problem Summary:

in tidb:

tidb(localhost:4000) > select last_day(str_to_date('202106', '%Y%m'));
+-----------------------------------------+
| last_day(str_to_date('202106', '%Y%m')) |
+-----------------------------------------+
| NULL                                    |
+-----------------------------------------+
1 row in set, 1 warning (0.00 sec)

tidb(localhost:4000) > set @@sql_mode = "";
Query OK, 0 rows affected (0.00 sec)

tidb(localhost:4000) > select last_day(str_to_date('202106', '%Y%m'));
+-----------------------------------------+
| last_day(str_to_date('202106', '%Y%m')) |                                                                                                                                             
+-----------------------------------------+
| NULL                                    |
+-----------------------------------------+
1 row in set, 1 warning (0.00 sec)

tidb(localhost:4000) > show warnings;
+---------+------+----------------------------------------+
| Level   | Code | Message                                |
+---------+------+----------------------------------------+
| Warning | 1292 | Incorrect datetime value: '2021-06-00' |
+---------+------+----------------------------------------+
1 row in set (0.00 sec)

in mysql 8.0.22

mysql > select last_day(str_to_date('202106', '%Y%m'));
+-----------------------------------------+
| last_day(str_to_date('202106', '%Y%m')) |
+-----------------------------------------+
| NULL                                    |
+-----------------------------------------+
1 row in set, 1 warning (0.00 sec)

mysql > set @@sql_mode="";
Query OK, 0 rows affected (0.01 sec)

mysql > select last_day(str_to_date('202106', '%Y%m'));
+-----------------------------------------+
| last_day(str_to_date('202106', '%Y%m')) |
+-----------------------------------------+
| 2021-06-30                              |
+-----------------------------------------+
1 row in set (0.00 sec)

What is changed and how it works?

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix incompatible last_day func behavior in sql mode

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2021
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2021
@tangenta
Copy link
Contributor

tangenta commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7af6308

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2021
@ti-chi-bot ti-chi-bot merged commit 5a07699 into pingcap:master Jul 6, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 6, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26000

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 6, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26001

@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_lastday branch July 6, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants