-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Log warnings when agg function can not be pushdown in explain statement (#25553) #25737
planner: Log warnings when agg function can not be pushdown in explain statement (#25553) #25737
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@fzhedu: Please use GitHub review feature instead of For the reason we drop support to the commands, see also this page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@windtalker: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4499af9
|
cherry-pick #25553 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25737
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
After #22713, if an expression can not be pushdown to storage layer, it will log a warning if current sql is an explain statement, however, for aggregation function
agg(expr)
if it can not be pushdown to storage layer becuaseexpr
is not supported, no warning is logged because current implementation callAggFuncToPBExpr
directly to check if the agg function can be pushed to storage layer.What is changed and how it works?
Proposal: xxx
What's Changed:
Refine
CheckAggCanPushCop
and log warnings when agg function can not be pushdown in explain statement.How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note