Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: disable partition table dynamic mode by default #25339

Merged
merged 3 commits into from
Jun 15, 2021
Merged

planner: disable partition table dynamic mode by default #25339

merged 3 commits into from
Jun 15, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 10, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: related to #24150

Problem Summary: planner: disable partition table dynamic mode by default

What is changed and how it works?

We decided to delay this feature to the next Sprint, so here we disable partition table dynamic mode by default.

Since this variable is set to dynamic for all test cases enforcedly at bootstrap.go:1616, we cannot add a unit case to check it, but I tested it manually in local and it is working.

Release note

  • No release note

@qw4990 qw4990 requested review from tiancaiamao and rebelice June 10, 2021 10:15
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 10, 2021

/run-all-tests

@ti-chi-bot
Copy link
Member

@tiancaiamao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

mjonss
mjonss approved these changes Jun 12, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm (but I'm not in the reviewers list yet)

@ti-chi-bot
Copy link
Member

@mjonss: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@mjonss: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/lgtm (but I'm not in the reviewers list yet)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@qw4990 qw4990 added sig/execution SIG execution and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d9a2bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2021
@ti-chi-bot ti-chi-bot merged commit 46ad95c into pingcap:master Jun 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@qw4990 @ti-srebot
cherry pick pingcap#25339 to release-5.1
4509895 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25403

ti-chi-bot pushed a commit that referenced this pull request Jun 15, 2021
@ti-srebot
planner: disable partition table dynamic mode by default (#25339) (#2…
0fc8d82 
…5403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@mjonss mjonss mjonss approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qw4990 @ti-chi-bot @tiancaiamao @ti-srebot @mjonss @rebelice