Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support str_to_date push to TiFlash (#25095) #25148

Merged
merged 6 commits into from
Jun 18, 2021
Merged

expression: support str_to_date push to TiFlash (#25095) #25148

merged 6 commits into from
Jun 18, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 4, 2021 •
edited
Loading

cherry-pick #25095 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25148

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25148:release-5.0-090892822b17

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: relate to pingcap/tiflash#1942

Problem Summary:
Function: push str_to_date to TiFlash.

What is changed and how it works?

Add push down support for str_to_date

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Support pushing down the str_to_date functions to TiFlash

@ti-srebot ti-srebot requested a review from a team as a code owner June 4, 2021 06:54
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team June 4, 2021 06:54
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Merged
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 4, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 4, 2021
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 4, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 4, 2021
@ti-srebot
Copy link
Contributor Author

@JaySon-Huang please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@JaySon-Huang
Copy link
Contributor

/milestone v5.0.3

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2021
@JaySon-Huang
Copy link
Contributor

Rely on #23661, do not merge this PR.
Or rewrite this cherry-pick PR.

@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 01:56
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2021
@zhouqiang-cl zhouqiang-cl added backport-5.0.3 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 18, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f67c4b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@JaySon-Huang
Copy link
Contributor

/milestone v5.0.3

@ti-chi-bot ti-chi-bot merged commit 4c5046f into pingcap:release-5.0 Jun 18, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.0-090892822b17 branch June 18, 2021 03:57
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.2, v5.0.3 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@AilinKid AilinKid AilinKid approved these changes

@jackysp jackysp Awaiting requested review from jackysp

@qw4990 qw4990 Awaiting requested review from qw4990

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees

@JaySon-Huang JaySon-Huang

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @JaySon-Huang @ti-chi-bot @AilinKid @xiongjiwei @zhouqiang-cl