Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more test cases about tiflash and dynamic mode #25111

Merged
merged 6 commits into from
Jun 4, 2021
Merged

planner: add more test cases about tiflash and dynamic mode #25111

merged 6 commits into from
Jun 4, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 3, 2021

What problem does this PR solve?

Issue Number: related to #24150

Problem Summary: planner: add more test cases about tiflash and dynamic mode

What is changed and how it works?

planner: add more test cases about tiflash and dynamic mode

Check List

Tests

  • Unit test

Release note

  • planner: add more test cases about tiflash and dynamic mode

@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 3, 2021
@qw4990 qw4990 requested review from rebelice and hanfei1991 June 3, 2021 12:35
@qw4990 qw4990 requested a review from a team as a code owner June 3, 2021 12:35
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team June 3, 2021 12:35
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 3, 2021
hanfei1991
hanfei1991 reviewed Jun 3, 2021
View reviewed changes
executor/tiflash_test.go
tk.MustExec(fmt.Sprintf("analyze table %v", tbl))
}

tk.MustExec("SET tidb_opt_broadcast_join=0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we check failpoint or use tidb_allow_mpp=2 to make sure we use mpp?

hanfei1991
hanfei1991 reviewed Jun 3, 2021
View reviewed changes
executor/tiflash_test.go
tk.MustExec(fmt.Sprintf("insert into %v values %v", tbl, strings.Join(vals, ", ")))
}

tk.MustExec("set @@session.tidb_isolation_read_engines='tiflash'")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

rebelice
rebelice reviewed Jun 4, 2021
View reviewed changes
executor/tiflash_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b18d37d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7602a27 into pingcap:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@rebelice rebelice rebelice approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @ti-chi-bot @rebelice @hanfei1991