-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support push down broadcast cartesian join to TiFlash (#25049) #25106
planner: support push down broadcast cartesian join to TiFlash (#25049) #25106
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
@windtalker Please resolve the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@fzhedu: Please use GitHub review feature instead of For the reason we drop support to the commands, see also this page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1a3c192
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a55e65d
|
cherry-pick #25049 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25106
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close pingcap/tiflash#1938
Problem Summary:
Currently, TiFlash does not support cartesian join, so TiDB will not push down cartesian join to TiFlash.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
After pingcap/tiflash#2041 TiFlash will support cartesian join, so in TiDB, it will push down a broadcast cartesian join to TiFlash.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note