Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support cast string as real push down #25096

Merged
merged 5 commits into from
Jun 3, 2021
Merged

expression: Support cast string as real push down #25096

merged 5 commits into from
Jun 3, 2021

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jun 3, 2021 •
edited
Loading

What problem does this PR solve?

Related to: pingcap/tiflash#1936
Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

  • Support CastStringAsReal push down to TiFlash

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • No release note.

@leiysky
expression: Support cast string as real push down (pingcap#24843)
d609994 
* support cast string as real push down

* add test
@leiysky leiysky requested a review from a team as a code owner June 3, 2021 08:39
@leiysky leiysky requested review from wshwsh12 and removed request for a team June 3, 2021 08:39
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/label needs-cherry-pick-5.0

@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/run-all-tests

zanmato1984
zanmato1984 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@LittleFall
Copy link
Contributor

LGTM

LittleFall
LittleFall approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@LittleFall
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d609994

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/merge

@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/merge

jackysp
jackysp approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leiysky
Copy link
Contributor Author

leiysky commented Jun 3, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit e2340c1 into pingcap:master Jun 3, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 3, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25109

@leiysky leiysky deleted the feature/support-cast-string-as-double-push-down branch June 3, 2021 12:55
ti-chi-bot pushed a commit that referenced this pull request Jun 17, 2021
@ti-srebot
expression: Support cast string as real push down (#25096) (#25109)
0358941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@jackysp jackysp jackysp approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leiysky @LittleFall @ti-chi-bot @ti-srebot @zanmato1984 @jackysp