Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix a panic caused by sinking a Limit with inlined Proj into IndexLookUp when accessing a partition table #25063

Merged
merged 15 commits into from
Jun 4, 2021
Merged

planner: fix a panic caused by sinking a Limit with inlined Proj into IndexLookUp when accessing a partition table #25063

merged 15 commits into from
Jun 4, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 2, 2021

What problem does this PR solve?

Issue Number: close #24636

Problem Summary: planner: fix a panic caused by sinking a Limit with inlined Proj into IndexLookUp when accessing a partition table

What is changed and how it works?

The root cause is that the two features Limit Sinking and Inline Projection are not compatible with each other under partition tables.

Check List

Tests

  • Unit test

Release note

  • planner: fix a panic caused by sinking a Limit with inlined Proj into IndexLookUp when accessing a partition table

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Jun 2, 2021
@qw4990 qw4990 requested review from winoros and rebelice June 2, 2021 11:11
@qw4990 qw4990 requested review from a team as code owners June 2, 2021 11:11
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team June 2, 2021 11:11
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 2, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/run-all-tests

@ichn-hu ichn-hu mentioned this pull request Jun 3, 2021
Closed
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 4, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c04ee04

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 4, 2021

/merge

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 4, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 4, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit b079428 into pingcap:master Jun 4, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 4, 2021
@qw4990 @ti-srebot
cherry pick pingcap#25063 to release-5.0
4099df9 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25139

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 18, 2021

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 18, 2021
@qw4990 @ti-srebot
cherry pick pingcap#25063 to release-5.1
c27b095 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25541

ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2021
@ti-srebot
planner: fix a panic caused by sinking a Limit with inlined Proj into…
7359a15 
… IndexLookUp when accessing a partition table (#25063) (#25139)
@Reminiscent Reminiscent mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@winoros winoros winoros approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong value when query a partition table with LIMIT
5 participants
@qw4990 @ti-chi-bot @ti-srebot @winoros @rebelice