Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case: make CTE case be stable #25035

Merged
merged 10 commits into from
Jun 2, 2021
Merged

case: make CTE case be stable #25035

merged 10 commits into from
Jun 2, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Jun 1, 2021 •
edited
Loading

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #25034

Problem Summary: CTETestSuite.TestSpillToDisk is unstable.

What is changed and how it works?

What's Changed:

  1. Change CTETestSuite.TestSpillToDisk to CTESerialTestSuite.TestSpillToDisk
  2. change code: Wait for the end of iterOutTbl's spilling to disk.
  3. On my local machine, run this test for 1000 times, the result looks good. go test . -test.count 1000 -check.f CTESerialTestSuite.TestSpillToDisk

Related changes

Check List

Side effects: no, just change case

Release note

  • No Release not

@guo-shaoge guo-shaoge requested a review from a team as a code owner June 1, 2021 10:47
@guo-shaoge guo-shaoge requested review from wshwsh12 and removed request for a team June 1, 2021 10:47
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-chi-bot
Copy link
Member

@AilinKid: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

AilinKid
AilinKid reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@guo-shaoge guo-shaoge changed the title case: fix cte case(CTETestSuite.TestSpillToDisk) case: make cte case be stable Jun 1, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Jun 1, 2021
@guo-shaoge guo-shaoge changed the title case: make cte case be stable case: make CTE case be stable Jun 1, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-check_release_note

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@guo-shaoge
Copy link
Collaborator Author

/run-common-test
/run-integration-common-test

guo-shaoge added 4 commits June 2, 2021 05:06
@guo-shaoge
fix cte case
588cde3 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
trivial change
9013231 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
trivial change
9584c2b 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
change code
034bca7 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Collaborator Author

/run-common-test
/run-integration-common-test

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-common-test
/run-integration-common-test

@guo-shaoge
Copy link
Collaborator Author

/rebuild

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2021
@wjhuang2016 wjhuang2016 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 034bca7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2021
@Rustin170506
Copy link
Member

/hold

@Rustin170506
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 2, 2021
@Rustin170506
Copy link
Member

/unhold

@xiongjiwei
Copy link
Contributor

/run-check_dev_2

@Rustin170506
Copy link
Member

@ti-chi-bot Help!

@wjhuang2016
Copy link
Member

/run-build

@wjhuang2016
Copy link
Member

/run-integration-br-test

@wjhuang2016
Copy link
Member

run-integration-ddl-test

@guo-shaoge
Copy link
Collaborator Author

/run-integration-ddl-test
/run-integration-br-test

@ti-chi-bot
Copy link
Member

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

2 similar comments
@Rustin170506
Copy link
Member

/run-unit-test

@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Jun 2, 2021 •
edited
Loading

/run-unit-test

Looks like we got race conditions. I will open an issue for this. #25066

@guo-shaoge guo-shaoge mentioned this pull request Jun 2, 2021
Closed
@ti-chi-bot ti-chi-bot merged commit 9fad132 into pingcap:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@ichn-hu ichn-hu ichn-hu approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

case unstable: CTETestSuite.TestSpillToDisk
9 participants
@guo-shaoge @ti-srebot @ti-chi-bot @zhouqiang-cl @wjhuang2016 @Rustin170506 @xiongjiwei @AilinKid @ichn-hu