Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add more cases about dynamic-mode with plan-cache and transaction #24998

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 31, 2021

What problem does this PR solve?

Issue Number: related to #24150

Problem Summary: executor: add more cases about dynamic-mode with plan-cache and transaction

What is changed and how it works?

No logical change, just add more cases about dynamic-mode with plan-cache and transaction

Check List

Tests

  • Unit test

Release note

  • executor: add more cases about dynamic-mode with plan-cache and transaction

@qw4990 qw4990 added sig/planner SIG: Planner sig/execution SIG execution labels May 31, 2021
@qw4990 qw4990 requested review from tiancaiamao and rebelice May 31, 2021 11:48
@qw4990 qw4990 requested review from a team as code owners May 31, 2021 11:48
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team May 31, 2021 11:48
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cf3160

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2021
@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 1, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 02b4f3b into pingcap:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants