Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: do not pushdown join to TiFlash if left condition/right condition is not empty while the join type is not left/right #24846

Merged
merged 10 commits into from
May 23, 2021
Merged

planner: do not pushdown join to TiFlash if left condition/right condition is not empty while the join type is not left/right #24846

merged 10 commits into from
May 23, 2021

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented May 23, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1963

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@windtalker windtalker requested a review from a team as a code owner May 23, 2021 11:52
@windtalker windtalker requested review from lzmhhh123 and removed request for a team May 23, 2021 11:52
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented May 23, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

zanmato1984
zanmato1984 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2021
@windtalker windtalker changed the title do not pushdown join to TiFlash if left condition/right condition is not empty while the join type is not left/right planner: do not pushdown join to TiFlash if left condition/right condition is not empty while the join type is not left/right May 23, 2021
@zanmato1984 zanmato1984 merged commit d405f06 into pingcap:hanfei/release5.0-hotfix-tiflash-patch May 23, 2021
windtalker added a commit to windtalker/tidb that referenced this pull request Jun 1, 2021
@windtalker
planner: do not pushdown join to TiFlash if left condition/right cond…
c43b446 
…ition is not empty while the join type is not left/right (pingcap#24846)

* support cross broadcast join

* save work

* save work

* support push down cartesian join to tiflash

* enable cartesian push down by default

* refine

* fix

* fix

* fix ci
@windtalker windtalker deleted the hanfei/release5.0-hotfix-tiflash-patch branch October 23, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@windtalker @ti-srebot @sre-bot @ti-chi-bot @zanmato1984