Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support pushdown cartesian join to TiFlash #24837

Merged
merged 8 commits into from
May 23, 2021
Merged

planner: support pushdown cartesian join to TiFlash #24837

merged 8 commits into from
May 23, 2021

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@windtalker windtalker requested a review from a team as a code owner May 22, 2021 05:24
@windtalker windtalker requested review from hanfei1991 and removed request for a team May 22, 2021 05:24
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label May 22, 2021
@windtalker windtalker mentioned this pull request May 22, 2021
Closed
zanmato1984
zanmato1984 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zanmato1984: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zanmato1984 zanmato1984 merged commit 88e1bee into pingcap:hanfei/release5.0-hotfix-tiflash-patch May 23, 2021
windtalker added a commit to windtalker/tidb that referenced this pull request Jun 1, 2021
@windtalker
planner: support pushdown cartesian join to TiFlash (pingcap#24837)
6389486 
* support cross broadcast join

* save work

* save work

* support push down cartesian join to tiflash

* enable cartesian push down by default

* refine

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @ti-chi-bot @zanmato1984