-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execution: fix the incorrect use of cached plan for point get (#24749) #24764
execution: fix the incorrect use of cached plan for point get (#24749) #24764
Conversation
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved ( AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2161992
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24749 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24764
After apply modifications, you can push your change to this PR via:
Signed-off-by: cfzjywxk [email protected]
What problem does this PR solve?
Issue Number: close #24741
Problem Summary:
The point get cached plan is used incorrectly for the in transaction prepare execution statement, which may change the transaction to invalid status unexpectedly and lead to panic or incorrect read.
What is changed and how it works?
What's Changed:
Use the
autocommitTxn
judge logic instead ofautocommit
.How it Works:
The autocommit mode flag and the in txn flag are different. In the
IsCachedExecOk
logic, only autocommit primary key point get read could use the cached plan.Related changes
Check List
Tests
Side effects
Release note