executor: add some test cases about dynamic-mode and apply operator #24683

qw4990 · 2021-05-17T07:20:59Z

What problem does this PR solve?

Issue Number: related to #24150

Problem Summary: executor: add some test cases about dynamic-mode and apply operator

What is changed and how it works?

No logical change, just add some test cases about dynamic-mode and apply operator.

Check List

Tests

Unit test

Release note

executor: add some test cases about dynamic-mode and apply operator

rebelice

/lgtm

tiancaiamao · 2021-05-19T01:57:06Z

executor/partition_table_test.go

+	tk.MustQuery(`select * from touter where touter.a > (select sum(thash.b) from thash ignore index(a) where thash.a>touter.b)`).Sort().Check(
+		tk.MustQuery(`select * from touter where touter.a > (select sum(tinner.b) from tinner ignore index(a) where tinner.a>touter.b)`).Sort().Rows())
+
+	// parallel apply + hash partition + IndexLookUp as its inner child


tinner is a non-partition table

Yes, it's expected. It's used to generate the correct result so that we can compare this result with results generated by partition tables.

tiancaiamao · 2021-05-19T01:58:13Z

executor/partition_table_test.go

+	tk.MustQuery(`select * from touter where touter.a > (select sum(trange.b) from trange ignore index(a) where trange.a>touter.b)`).Sort().Check(
+		tk.MustQuery(`select * from touter where touter.a > (select sum(tinner.b) from tinner ignore index(a) where tinner.a>touter.b)`).Sort().Rows())
+
+	// parallel apply + range partition + IndexLookUp as its inner child


tiancaiamao · 2021-05-19T02:02:25Z

/LGTM

ti-chi-bot · 2021-05-19T02:02:27Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

rebelice
tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

qw4990 · 2021-05-19T03:28:08Z

/merge

ti-chi-bot · 2021-05-19T03:28:13Z

This pull request has been accepted and is ready to merge.

Commit hash: 8b30588

ti-chi-bot · 2021-05-19T05:08:53Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

qw4990 · 2021-05-19T06:12:56Z

/run-unit-test

qw4990 · 2021-05-19T06:36:41Z

/merge

ti-chi-bot · 2021-05-19T08:45:53Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-19T12:22:54Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

purelind · 2021-05-19T14:05:15Z

/run-build

ti-chi-bot · 2021-05-19T16:30:53Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-19T18:34:53Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-19T19:17:54Z

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…ingcap#24052) * *: fix revoke statement for CURRENT_USER() and refine error message planner: support set tidb_allow_mpp to `2` or `ENFORCE` to enforce use mpp mode. (pingcap#24516) store/tikv: remove use of SchemaAmender option in store/tikv (pingcap#24408) *: the value of tikv-client.store-liveness-timeout should not less than 0 (pingcap#24244) store/tikv: remove use of EnableAsyncCommit option in store/tikv (pingcap#24462) txn: Add txn state's view (pingcap#22908) planner: ignore lock for temporary table of PointGet and BatchPointGet (pingcap#24540) store/tikv: remove use of ReplicaRead transaction option in store/tikv (pingcap#24409) store/driver: move error to single package (pingcap#24549) ddl: add check table compatibility for temporary table (pingcap#24501) store/tikv: remove use of IsStatenessReadOnly option in store/tikv (pingcap#24464) store/tikv: change backoff type for missed tiflash peer. (pingcap#24577) store/tikv: remove use of MatchStoreLabels transaction option in store/tikv (pingcap#24465) executor, meta: Allocate auto id for global temporary tables (pingcap#24506) store/tikv: remove use of SampleStep option in store/tikv (pingcap#24461) executor: add partition pruning tests for adding and dropping partition operations (pingcap#24573) ddl: forbid partition on temporary mode before put into queue (pingcap#24565) ddl: speedup test case TestIndexOnMultipleGeneratedColumn (pingcap#24487) execution: Fix issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* (pingcap#24485) *: fix errcheck (pingcap#24463) test: make TestExtractStartTs stable (pingcap#24585) ddl: forbid recover/flashback temporary tables (pingcap#24518) executor: fix point_get result on clustered index when new-row-format disabled but new-collation enabled (pingcap#24544) executor: Improve the performance of appending not fixed columns (pingcap#20969) *: typo fix (pingcap#24564) planner/core: refresh stale regions in cache for batch cop response (pingcap#24457) binlog: DML on temporary tables do not write binlog (pingcap#24570) store/tikv: remove use of GuaranteeLinearizability option in store/tikv (pingcap#24605) store/tikv: remove use of CollectRuntimeStats option in store/tikv (pingcap#24604) store/tikv: move Backoffer into a single package (pingcap#24525) variables: init cte max recursive deeps in a new session (pingcap#24609) store/tikv: move transaction options out to /kv (pingcap#24619) store/driver: move backoff driver into single package so we can use i… (pingcap#24624) server: close the temporary session in HTTP API to avoid memory leak (pingcap#24339) store/tikv: use latest PD TS plus one as min commit ts (pingcap#24579) planner: fix incorrect TableDual plan built from nulleq (pingcap#24596) ranger: fix the case which could have duplicate ranges (pingcap#24590) executor, store: Pass the SQL digest down to pessimistic lock request (pingcap#24380) kv: remove UnionStore interface (pingcap#24625) *: enable gosimple linter (pingcap#24617) txn: avoid the gc resolving pessimistic locks of ongoing transactions (pingcap#24601) util: fix wrong enum building for index range (pingcap#24632) sessionctx: change innodb large prefix default (pingcap#24555) store: fix data race about KVStore.tikvClient (pingcap#24655) executor, privileges: Add dynamic privileges to SHOW PRIVILEGES (pingcap#24646) ddl: refactor rule [4/6] (pingcap#24007) cmd: ddl_test modify retryCnt from 5 to 20 (pingcap#24662) executor: add correctness tests about direct reading with ORDER BY and LIMIT (pingcap#24455) store/tikv: remove options from unionstore (pingcap#24629) planner: fix wrongly check for update statement (pingcap#24614) store/tikv: remove CompareTS (pingcap#24657) planner, privilege: Add security enhanced mode part 4 (pingcap#24416) executor: add some test cases about partition table dynamic-mode with split-region (pingcap#24665) planner: fix wrong column offsets when processing dynamic pruning for IndexJoin (pingcap#24659) *: Add security enhanced mode part 3 (pingcap#24412) store/tikv: resolve ReplicaReadType dependencies (pingcap#24653) executor: add test cases about partition table with `expression` (pingcap#24628) tablecodec: fix write wrong prefix index value when collation is ascii_bin/latin1_bin (pingcap#24578) *: compatibility with staleread (pingcap#24285) session: test that temporary tables will also be retried (pingcap#24505) domain, session: Add new sysvarcache to replace global values cache (pingcap#24359) ddl, transaction: DDL on temporary tables won't affect transactions (pingcap#24534) *: implement tidb_bounded_staleness built-in function (pingcap#24328) executor: add correctness tests for partition table with different joins (pingcap#24673) expression: fix the spelling of word arithmetical (pingcap#24713) store/copr: balance region for batch cop task (pingcap#24521) store, metrics: Add metrics for safetTS updating (pingcap#24687) sem: add tidbredact log to restricted variables (pingcap#24701) session: fix dml_batch_size doesn't load the global variable (pingcap#24710) store/tikv: retry TSO RPC (pingcap#24682) expression, planner: push cast down to control function with enum type. (pingcap#24542) executor: add correctness tests about IndexMerge (pingcap#24674) variable: change default for DefDMLBatchSize tidbOptInt64 call (pingcap#24697) planner: add partitioning pruning tests for range partitioning (pingcap#24554) *: add option for enum push down (pingcap#24685) txn: break dependency from store/tikv to tidb/kv cause by TransactionOption (pingcap#24656) executor: enhancement for ListInDisk(support writing after reading) (pingcap#24379) kv: move TxnScope into kv (pingcap#24715) execution: fix the incorrect use of cached plan for point get (pingcap#24749) executor: add correctness tests about direct reading with indexJoin (pingcap#24497) variable: fix sysvar datarace with deep copy (pingcap#24732) *: Implementing RENAME USER (pingcap#24413) infoschema, executor: Add the deadlock table (pingcap#24524) docs: Some proposal for renaming and configurations for Lock View (pingcap#24718) planner: add range partition boundaries tests with BETWEEN expression (pingcap#24598) oracle: simplify timestamp utilities (pingcap#24688) executor: fix wrong enum key in point get (pingcap#24618) ranger: fix incorrect enum range for xxx_ci collation (pingcap#24661) executor: add some test cases about dynamic-mode and apply operator (pingcap#24683) store/tikv: remove Variables.Hook (pingcap#24758) ddl: speed up the execution time of `TestBackwardCompatibility`. (pingcap#24704) *: prepare errors for CTE (pingcap#24763) expression: support cast real/int as real (pingcap#24670) executor: add table name in log (pingcap#24666) expression: add builtin function ``json_pretty`` (pingcap#24675) ddl: make `TestDropLastVisibleColumns` stable (pingcap#24790) * ddl: make `TestDropLastVisibleColumns` stable *: support AS OF TIMESTAMP read-only begin statement (pingcap#24740) executor: Fix unstable TestTiDBLastTxnInfoCommitMode (pingcap#24779) planner: add tests for partition range boundaries for LT/GT (pingcap#24574) test: record random seed in TestIssue20658 (pingcap#24782) store/tikv/retry: define Config instead of BackoffType (pingcap#24692) config: ignore tiflash when show config (pingcap#24770) privileges: improve dynamic privs registration and tests (pingcap#24773) README: remove the link of TiDB Monthly Update (pingcap#24791) region_cache: filter peers on tombstone or dropped stores (pingcap#24726) util/stmtsummary: remove import package tikv (pingcap#24776) ddl: grammar check for create unsupported temporary table (pingcap#24723) *: update go.etcd.io/bbolt (pingcap#24799) ddl: speed up the execution time of `ddl test` and `Test Chunk pingcap#7 ddl-other` (pingcap#24780) executor: remove the unnecessary use of fmt.Sprintf (pingcap#24815) executor: fix index join panic on prefix index on some cases (pingcap#24568)

add some cases about apply

ab2a29f

qw4990 added sig/planner SIG: Planner sig/execution SIG execution labels May 17, 2021

qw4990 requested review from wshwsh12 and rebelice May 17, 2021 07:21

qw4990 requested a review from a team as a code owner May 17, 2021 07:21

ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2021

qw4990 added 2 commits May 17, 2021 15:55

add random queries

8738669

make linter happy

997b059

rebelice approved these changes May 18, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2021

qw4990 requested a review from mjonss May 18, 2021 07:05

tiancaiamao reviewed May 19, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2021

Merge branch 'master' into dynamicmode-apply

8b30588

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2021

Merge branch 'master' into dynamicmode-apply

ba8aaa0

Merge branch 'master' into dynamicmode-apply

5a13489

ti-chi-bot added 2 commits May 19, 2021 20:23

Merge branch 'master' into dynamicmode-apply

acc2c8a

Merge branch 'master' into dynamicmode-apply

22f19cc

Merge branch 'master' into dynamicmode-apply

0e4870d

Merge branch 'master' into dynamicmode-apply

3e78cf7

ti-chi-bot added 2 commits May 20, 2021 02:35

Merge branch 'master' into dynamicmode-apply

7d92d58

Merge branch 'master' into dynamicmode-apply

28436d5

ti-chi-bot merged commit 20e467a into pingcap:master May 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: add some test cases about dynamic-mode and apply operator #24683

executor: add some test cases about dynamic-mode and apply operator #24683

qw4990 commented May 17, 2021

rebelice left a comment

tiancaiamao May 19, 2021

qw4990 May 19, 2021

tiancaiamao May 19, 2021

tiancaiamao commented May 19, 2021

ti-chi-bot commented May 19, 2021

qw4990 commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

qw4990 commented May 19, 2021

qw4990 commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

purelind commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

executor: add some test cases about dynamic-mode and apply operator #24683

executor: add some test cases about dynamic-mode and apply operator #24683

Conversation

qw4990 commented May 17, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

rebelice left a comment

Choose a reason for hiding this comment

tiancaiamao May 19, 2021

Choose a reason for hiding this comment

qw4990 May 19, 2021

Choose a reason for hiding this comment

tiancaiamao May 19, 2021

Choose a reason for hiding this comment

tiancaiamao commented May 19, 2021

ti-chi-bot commented May 19, 2021

qw4990 commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

qw4990 commented May 19, 2021

qw4990 commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

purelind commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021