Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablecodec: fix write wrong prefix index value when collation is ascii_bin/latin1_bin (#24578) #24680

Merged
merged 1 commit into from
May 26, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 17, 2021

cherry-pick #24578 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24680

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24680:release-5.0-ae36fbdb316f

What problem does this PR solve?

Issue Number:

close #24569
info #24548 (only address #24548 (comment), mainly issue seems have some other problem in tikv side)

Problem Summary:

prefix index will truncate value during insert, but for not utf8 collation, the code is wrong, it change type from string to bytes when handing truncate value to prefix len, at last, encode key will treat it as bytes and miss handling collation's trim space logic.

this issue need:

  • prefix column index
  • end with space after trimmed to the prefix length

the question maybe meet:

  • unique index's duplicate check doesn't work for clustered or nonclustered index table
  • admin check table should be fail when table is clustered index table

What is changed and how it works?

What's Changed, How it Works:

set it as string type if before truncating it's string type.

Related changes

  • Need to cherry-pick to the release branch 5.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • Fix write wrong prefix index value when collation is ascii_bin/latin1_bin

@ti-srebot ti-srebot requested a review from a team as a code owner May 17, 2021 06:38
@ti-srebot ti-srebot requested review from qw4990 and removed request for a team May 17, 2021 06:38
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/PTAL type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels May 17, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone May 17, 2021
@ti-srebot
Copy link
Contributor Author

@lysu you're already a collaborator in bot's repo.

Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2021
@wjhuang2016
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2021
@lysu
Copy link
Contributor

lysu commented May 20, 2021

@sticnarf CI seems back to green, please help merge again if free ~ :)

@ti-chi-bot
Copy link
Member

@sticnarf: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sticnarf
Copy link
Contributor

@sticnarf CI seems back to green, please help merge again if free ~ :)

To my understanding, only the release manager can merge the PRs into release branches.

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e15f879

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 26, 2021
@ti-chi-bot ti-chi-bot merged commit 2c66561 into pingcap:release-5.0 May 26, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.1, v5.0.2 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants