Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: solve the compatibility problem between UnionScan and partition tables and remove all code about PartitionTableExec #24394

Merged
merged 3 commits into from
May 6, 2021
Merged

executor: solve the compatibility problem between UnionScan and partition tables and remove all code about PartitionTableExec #24394

merged 3 commits into from
May 6, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 30, 2021

What problem does this PR solve?

Issue Number: close #24393

Problem Summary: executor: solve the compatibility problem between UnionScan and partition tables and remove all code about PartitionTableExec

What is changed and how it works?

Since all DataSource operators (like TableReader, IndexLookUp ...) have already supported reading partition table directly, so PartitionTableExec is unused now, and all code about it can be removed.

There are already some test cases about UnionScan in partition_table_test.go, so I didn't introduce any new case.

Check List

Tests

  • Unit test

Release note

  • executor: solve the compatibility problem between UnionScan and partition tables and remove all code about PartitionTableExec

@qw4990 qw4990 added the sig/execution SIG execution label Apr 30, 2021
@qw4990 qw4990 requested a review from a team as a code owner April 30, 2021 03:09
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team April 30, 2021 03:09
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2021
@qw4990 qw4990 requested review from lysu, wshwsh12 and tiancaiamao April 30, 2021 03:10
@qw4990 qw4990 mentioned this pull request Apr 30, 2021
Closed
60 tasks
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 30, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented May 6, 2021

PTAL @wshwsh12 @lysu @tiancaiamao

@lysu
Copy link
Contributor

lysu commented May 6, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
@wshwsh12
Copy link
Contributor

wshwsh12 commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented May 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8db518f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented May 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented May 6, 2021

/run-integration-common-test

@qw4990
Copy link
Contributor Author

qw4990 commented May 6, 2021

/run-unit-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented May 6, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit cb74578 into pingcap:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@lysu lysu Awaiting requested review from lysu

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove all code about PartitionTableExec
4 participants
@qw4990 @lysu @wshwsh12 @ti-chi-bot