-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make IndexLookUps in the inner side of IndexJoins support direct reading #24261
Conversation
This PR has the same behavior as #24260, please help us review it at your convenience, @lysu @tiancaiamao . |
Could you please help us review this small PR? @wshwsh12 Very appreciate it! |
PTAL @wshwsh12 @tiancaiamao |
/LGTM |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5f1a098
|
@qw4990: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
/run-integration-ddl-test |
/run-common-test |
/run-unit-test |
What problem does this PR solve?
Issue Number: close #24256
Problem Summary: executor: make IndexLookUps in the inner side of IndexJoins support direct reading
What is changed and how it works?
Please see more details at #24256.
In this PR, we:
IndexLookUp
directly instead of usingPartitionExecForIndexLookUp
to read partition table;PartitionExecForIndexLookUp
;Check List
Tests
Release note