Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make IndexLookUps in the inner side of IndexJoins support direct reading #24261

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 25, 2021

What problem does this PR solve?

Issue Number: close #24256

Problem Summary: executor: make IndexLookUps in the inner side of IndexJoins support direct reading

What is changed and how it works?

Please see more details at #24256.
In this PR, we:

  1. use IndexLookUp directly instead of using PartitionExecForIndexLookUp to read partition table;
  2. remove PartitionExecForIndexLookUp;
  3. add a test case;

Check List

Tests

  • Unit test

Release note

  • executor: make IndexLookUps in the inner side of IndexJoins support direct reading

@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Apr 25, 2021
@qw4990 qw4990 requested review from lysu and tiancaiamao April 25, 2021 06:38
@qw4990 qw4990 requested a review from a team as a code owner April 25, 2021 06:38
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team April 25, 2021 06:38
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 25, 2021

This PR has the same behavior as #24260, please help us review it at your convenience, @lysu @tiancaiamao .
Very appreciate!

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2021

Could you please help us review this small PR? @wshwsh12 Very appreciate it!

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

PTAL @wshwsh12 @tiancaiamao

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021
@wshwsh12
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5f1a098

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2021
@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/run-integration-ddl-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/run-common-test

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 5c83f0b into pingcap:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make IndexLookups in the inner side of IndexJoins support direct reading
4 participants