-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: quickly process the next job after processing the cancelled DDL job (#24146) #24254
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@zimulala please accept the invitation then you can push to the cherry-pick pull requests. |
/lgtm |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e531e87
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
It's not very urgent, so we don't merge it into 5.0. |
cherry-pick #24146 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24254
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
When the owner and the receiving DDL TiDB are on the same TiDB, quickly process the next job after processing the canceled DDL job.
What is changed and how it works?
When the DDL job is "JobStateRollbackDone", we notify the receiving DDL TiDB to process the finished job.
Add a log after the DDL JOB fails.
What's Changed:
How it Works:
This optimization also enables faster testing.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
This optimization also enables faster testing.
Before this PR:
Executing
go test
takes 196.455s in the DDL package.After this PR:
Executing
go test
takes 134.877s in the DDL package.Release note