Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: make IndexMergeReader support reading partition table directly #24239

Merged
merged 28 commits into from
Apr 27, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 23, 2021

What problem does this PR solve?

Issue Number: close #24160

Problem Summary: executor: make IndexMergeReader support reading partition table directly

What is changed and how it works?

This PR makes IndexMergeReader support reading partition tables directly using the similar way with #24197.

The picture below shows how we implement this feature:

  1. build KVReq for each partition table separately;
  2. let IndexWorker and PKWorker handle these KVReqs one by one;
  3. delivery partition information to MergeWorker and TableWorker as well;
    image

Check List

Tests

  • Unit test

Release note

  • executor: make IndexMergeReader support reading partition table directly

@qw4990 qw4990 requested review from lysu and tiancaiamao April 23, 2021 10:15
@qw4990 qw4990 requested a review from a team as a code owner April 23, 2021 10:15
@qw4990 qw4990 requested review from lzmhhh123 and removed request for a team April 23, 2021 10:15
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 23, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 23, 2021

Please help us review this PR at your convenience, @lysu @tiancaiamao
Very appreciate your reviews 🧎 !

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 23, 2021

/run-all-tests

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2021

Thanks, @tiancaiamao , and PTAL at your convenience @lysu

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2021
@lysu lysu added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@lysu
Copy link
Contributor

lysu commented Apr 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c08596

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 31238d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b0799b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 26, 2021

/run-all-tests

@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

1 similar comment
@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 777887b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2021
@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 27, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit d67beef into pingcap:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reading partition table for index merge reader
5 participants