-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make IndexMergeReader support reading partition table directly #24239
Conversation
Please help us review this PR at your convenience, @lysu @tiancaiamao |
/run-all-tests |
/LGTM |
Thanks, @tiancaiamao , and PTAL at your convenience @lysu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1c08596
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 31238d8
|
/run-all-tests |
…/tidb into IndexMerge-direct-reading
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8b0799b
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/run-all-tests |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
1 similar comment
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
/merge |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 777887b
|
@qw4990: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
What problem does this PR solve?
Issue Number: close #24160
Problem Summary: executor: make IndexMergeReader support reading partition table directly
What is changed and how it works?
This PR makes
IndexMergeReader
support reading partition tables directly using the similar way with #24197.The picture below shows how we implement this feature:
KVReq
for each partition table separately;IndexWorker
andPKWorker
handle theseKVReqs
one by one;MergeWorker
andTableWorker
as well;Check List
Tests
Release note