Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix Join reorder occurs "index out of range" error #24102

Merged
merged 12 commits into from
Apr 21, 2021

Conversation

mmyj
Copy link
Member

@mmyj mmyj commented Apr 19, 2021

What problem does this PR solve?

Issue Number: close #24095

Problem Summary:

for i, col := range p.Schema().Columns {
  if !col.Equal(nil, originalSchema.Columns[i]) {
	  schemaChanged = true
	  break
  }
}

Panic when len(p.Schema().Columns) != len(originalSchema.Columns)

What is changed and how it works?

Related changes

Check List

Tests

  • Unit test

Release note

  • Fix Join reorder occurs "index out of range" error

@mmyj mmyj requested a review from a team as a code owner April 19, 2021 02:04
@mmyj mmyj requested review from eurekaka and removed request for a team April 19, 2021 02:04
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2021
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-check-title

2 similar comments
@zhouqiang-cl
Copy link
Contributor

/run-check-title

@purelind
Copy link
Contributor

/run-check-title

@purelind
Copy link
Contributor

/run-all-tests

@ichn-hu ichn-hu mentioned this pull request Apr 19, 2021
@dianqihanwangzi
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • hanfei1991

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2021
@eurekaka
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef621af

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2021
@eurekaka eurekaka added sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Apr 21, 2021
@qw4990
Copy link
Contributor

qw4990 commented Dec 20, 2021

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 20, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #30881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join reorder occurs "index out of range" error
9 participants